🤖 feat: add Windows compatibility to Makefile build system #571
+41
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add RUNNER variable that uses npx on Windows, bun x elsewhere - Windows: bun x doesn't correctly pass arguments, so use npm run/npx - Non-Windows: Continue using bun x for better performance - Update all commands to use $(RUNNER) instead of hardcoded bun x - Add comments explaining why Windows needs different approach This ensures consistent build behavior across all platforms while working around Windows-specific limitations with bun's argument passing.
Contributor
Author
|
Closing as these changes have been added to PR #540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The build system has issues on Windows because
bun xdoesn't correctly pass arguments on Windows platforms. This causes various build commands to fail or behave unexpectedly.Solution
Introduce a platform-specific
RUNNERvariable that:npxon Windows (wherebun xhas argument passing issues)bun xon other platforms (for better performance)All commands throughout the Makefile now use
$(RUNNER)instead of hardcodedbun x, ensuring consistent behavior across platforms.Changes
RUNNERvariable conditionally based on OSbun xcalls with$(RUNNER)Testing
Generated with
cmux