-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable "Show Local" button, add --disable-file-uploads option and add file operation trace level logs #6557
Conversation
…ble and add trace logs for file read/write operations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you again.
Some unrelated e2e tests are failing, maybe the switch from text
to text-is
? Could be it was matching on partial strings before.
One quirk: seems I can edit local files by dragging them to the editor pane, do we want to block that as well? |
I was looking at that as well.. best I could tell that was actually editing them in place (on the client machine with the client needing to give the browser permissions on the directory) and not actually uploading them to the server. Does that match what you are seeing? |
Yup, that is what I was seeing. My reasoning was that since we remove the "show local" button for opening files (which seems to be doing the same thing) we would want to prevent this as well otherwise it is possible to bypass the button removal by dragging instead. You bring up a good point that it is not actually uploading anything though so leaving it as-is seems fine to me. |
Is there anything else I need to do, is that prettier error real? |
It claims "should show the Integrated Terminal" and "should have access to VSCODE_PROXY_URI" are failing. Maybe For the Prettier errors, I ran |
Oh wait I think |
@code-asher I ran |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6557 +/- ##
=======================================
Coverage 73.13% 73.13%
=======================================
Files 31 31
Lines 1906 1906
Branches 409 409
=======================================
Hits 1394 1394
Misses 433 433
Partials 79 79
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! Awesome to have this in.
…d file operation trace level logs (coder#6557)
This PR replaces PR #6529. It adds an option to disable file uploads (--disable-file-uploads) and removes the "Show Local" button on the dialog box for relevant file actions for both --disable-file-uploads and --disable-file-downloads options (fix #5118). It also adds trace level log statements for files that are read from or saved to disk.