Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆ Update and organize apt packages #6581

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

bdsoha
Copy link
Contributor

@bdsoha bdsoha commented Dec 13, 2023

Description

  • Use man-db instead of man (as proposed by apt)
  • Use vim-tiny instead of vim.tiny (as proposed by apt)
  • Sort requirements alphabetically
  • Update fixuid version
  • Add wget to the base package list as it is widely used and available by default on many Linux distros.

Regarding the suggestion to use --no-install-recommends from #6574, the difference between the two installs is minor:

- 1 upgraded, 74 newly installed, 0 to remove and 5 not upgraded.
+ 1 upgraded, 53 newly installed, 0 to remove and 5 not upgraded.
- After this operation, 200 MB of additional disk space will be used.
+ After this operation, 190 MB of additional disk space will be used.

As a conclusion, it is not worth the ~10MB to possibly cause regressions.

@bdsoha bdsoha requested a review from a team as a code owner December 13, 2023 06:14
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates and the analysis!

@code-asher code-asher enabled auto-merge (squash) December 15, 2023 20:03
@code-asher code-asher merged commit d9fe46a into coder:main Dec 15, 2023
9 checks passed
@bdsoha bdsoha deleted the feature/update-deb-package-list branch December 16, 2023 16:13
yiliang114 pushed a commit to yiliang114/code-server that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants