🤖 fix: map aggregated OpenAPI schemas to GVK for SSA#83
Merged
Conversation
Add GVK extensions and top-level object metadata fields to the aggregated API server's manual OpenAPI schemas so managedfields can map aggregation.coder.com/v1alpha1 objects to SMD types. Also add regression tests that verify: - CoderTemplate schema exposes x-kubernetes-group-version-kind and object fields - managedfields type conversion succeeds for CoderTemplate objects --- _Generated with [`mux`](https://github.com/coder/mux) • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh`_ --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.29`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.29 -->
Member
Author
|
@codex review Please review this change for SSA compatibility and OpenAPI schema correctness. |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix aggregated API OpenAPI model metadata so server-side apply can map
aggregation.coder.com/v1alpha1resources to structured-merge-diff types.Background
kubectl apply --server-sidewas failing during managed fields processing with:failed to convert new object to smd typedno corresponding type for aggregation.coder.com/v1alpha1, Kind=CoderTemplateThe aggregated API server defines OpenAPI schemas manually, but those definitions were missing the
x-kubernetes-group-version-kindextension that managedfields uses to index object types.Implementation
x-kubernetes-group-version-kindextensions to manual OpenAPI definitions for:CoderWorkspaceCoderWorkspaceListCoderTemplateCoderTemplateListapiVersion,kind,metadata) and list metadata fields.TypeConvertercan convert aCoderTemplateobject to SMD typed formValidation
make verify-vendormake testmake buildmake lintGOFLAGS=-mod=vendor go test ./internal/app/apiserverapp -count=1Risks
Low-to-moderate:
Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhighGenerated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.29