**DO NOT CLOSE** Notification V2 #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang has added a new warning for virtual specifiers on methods of `final` classes. This cleans them up in preparation for enabling that warning. Bug: chromium:403236787 Change-Id: I1bb144494028f674d0de409a65412af1f084b56c Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6391658 Commit-Queue: Mark Foltz <mfoltz@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Currently, Chromium openscreen builders are failing for timeout since remote execution is disabled. https://ci.chromium.org/ui/p/openscreen/builders/try/chromium_linux_x64/b8719177567471980433/overview Those builders need to switch from Ninja to Siso. The new properties are necessary for the migration. Bug: 379584977 Change-Id: I52f42dcc247a70cf609e0fcfd6c916ed914ba531 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6436889 Reviewed-by: Mark Foltz <mfoltz@chromium.org>
This patch resolves a longish standing TODO to move the statistics generation code out of the Sender class and into its own, unit tested class. This class is called StatisticsDispatcher. Bug: 298277160 Change-Id: I755beb6c4222f65a94a9b5503a708c431e52bc1b Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6398046 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Muyao Xu <muyaoxu@google.com>
The chromium builders don't use Reclient anymore. Bug: 379584977 Change-Id: I2071ea6c93c3af80e19a82dfd93ddf25fbbf5725 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6439985 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Closed
Clang maps -Wall (or /Wall) to -Weverything on windows, so it causes low-value warnings to trigger during out build. Instead, we should use /W4, which corresponds to gcc's `-Wall -Wextra`. Bug: chromium:410803303 Change-Id: Id512338bf412794e4b7278e7b6332bc44fe74305 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6457698 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
This patch improves error messaging around certificate loading, especially private keys. Change-Id: I5c00b44a9bed04ec51826d78805b0cb29f90e855 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6473163 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Muyao Xu <muyaoxu@google.com>
See comment on https://chromium-review.googlesource.com/c/openscreen/+/6457698 This config mostly exists to disable -Wshadow for one cc file. Instead, just build that one file as no_chromium_code. No effective behavior change. Bug: chromium:410803303 Change-Id: I952057f0a31f0a150926c55e65fd6ade89b93807 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6483407 Commit-Queue: Mark Foltz <mfoltz@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org>
This patch fixes a critical infra failure where the build is currently broken due to a minor speed improvement made to the clang update script. This patch rolls the build and buildtools submodules as well as updates the clang update download script to pull a specific version of the update script, to avoid breaking changes like this in the future. Change-Id: I975ecaf1667cf03c57ac3f7bd15314b1c54281a9 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6544748 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This patch updates the platform implementation to not subscribe to wait events for UDP sockets. It is part of a larger cleanup to improve the amount of time spent in loops in the platform implementation. Change-Id: Ib09474a1ee05629770acd6b2d7893276bb965e79 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6539456 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This patch optimizes a check for Writable handles, ensuring that we don't pass a handle to the write argument for select() if we don't have anything to write. This lowers the amount of cycles spent polling the select loop. This is a not-insignificant change, involving updating the SocketHandleWaiter interface and its subscribers to allow the waiter to poll for whether the socket has pending write events or not. Change-Id: Icbd38a67fbc1fa4856f9605d6306971568dcca5e Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6556928 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This also requires a change in chromium/src. Bug: b:374199735 Change-Id: I76bc61259d939ff8c87aba84650f228de92c5c2e Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6533602 Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Antonio Rivera <antoniori@google.com>
Also updated protobuf revision to match the current version. Bug: 421988683, 421989590, 421989329, 421989630, 421989709, 421988806, 421989809, 421988937 Change-Id: I45e3cbc029bee0f5f04e2fb0c8f76c9415b7eeba Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6768426 Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Jordan Brown <rop@google.com>
takumif@ is no longer on the team. Change-Id: Ie42bf4e833253c12346e43434457c60a87e2b9f6 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6882217 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Python3 is used by default in recipes now and this config is not necessary anymore. Bug: 440235171 Change-Id: I89d420b8481fe5af08704939f74033226fd511ba Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6888255 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Bug: None Change-Id: I6dc21fff88a8e61806e98defb5178ce4bd8bcc3a Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6896306 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Not needed and deprecated [0]. This CL should be a no-op. [0]: https://chromium.googlesource.com/external/github.com/google/googletest.git/+/a05c0915074bcd1b82f232e081da9bb6c205c28d/googlemock/include/gmock/gmock-actions.h#2046 Bug: chromium:439838457 Test: `openscreen_unittests` in Chromium Change-Id: I73446be5df46235049139edde087dfa17f7ded15 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6897917 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Not needed and deprecated [0]. This CL should be a no-op. [0]: https://chromium.googlesource.com/external/github.com/google/googletest.git/+/a05c0915074bcd1b82f232e081da9bb6c205c28d/googlemock/include/gmock/gmock-actions.h#2046 Bug: chromium:439838457 Test: `openscreen_unittests` in Chromium Change-Id: Ib4ef3f314a6b0348ac276c7145b5f5862b09853c Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6897919 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Not needed and deprecated [0]. This CL should be a no-op. [0]: https://chromium.googlesource.com/external/github.com/google/googletest.git/+/a05c0915074bcd1b82f232e081da9bb6c205c28d/googlemock/include/gmock/gmock-actions.h#2046 Bug: chromium:439838457 Test: `openscreen_unittests` in Chromium Change-Id: If131ba9ea908a1f2918dc9e712821341714a35a1 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6897920 Commit-Queue: Mark Foltz <mfoltz@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org>
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/b514bdc898e2..eb2d85edd0bf $ git log b514bdc89..eb2d85edd --date=short --no-merges --format='%ad %ae %s' 2025-08-24 absl-team Remove unused syslog dependency for Fuchsia. 2025-08-19 absl-team Internal header include changes. 2025-08-16 absl-team Deprecate single-argument DoAll and Invoke. 2025-08-11 absl-team Update the document in typed tests to use using-declaration instead of typedef 2025-07-28 absl-team Provide a better error message when ASSERT and SKIP macros are used in methods that return values 2025-07-23 absl-team Skip the predicate on SIGSEGV in death-test on Android builds with API level <= 23. 2025-07-18 absl-team Fix the sample usage of `ConvertGenerator` by removing the type-id name. 2025-07-12 absl-team Automated Code Change 2025-07-04 absl-team Replace internal link in GoogleTest docs 2025-06-27 pizzud gtest: Reword fail_if_no_test_selected_message for sharding and filtering. 2025-06-24 absl-team Add documentation for exception matchers. 2025-06-13 absl-team Although the following paragraph explains there is a better solution, having this technique in the bullet point seems to suggest that this technique is considered as a valid alternative. It would be better to drop it or make it clear that this technique is not recommended. 2025-06-12 absl-team Add UnpackStructImpl for structs with 24, 25 and 26 fields. 2025-06-11 joel.langlois README.md: Fixed broken Markdown link formatting. 2025-06-10 absl-team Automated Code Change 2025-06-09 absl-team In MatcherCast, store the input value as its own type rather than as the Matcher type, to avoid dangling references 2025-06-09 pizzud googletest: Add a flag to fail if no tests were selected to run. 2025-06-05 absl-team Remove "blindly" from the gmock "uninteresting call" message. 2025-05-30 absl-team Fix unified diff headers. 2025-05-30 absl-team Use the provided length in ConditionalPrintAsText 2025-05-25 nextgen.gubka Fix extra ';' after member function definition 2025-05-22 absl-team Updates Google Analytics tracker. 2025-05-22 dcheng Print std::basic_string_view<Char> as a string literal 2025-05-20 dmauro Delete the absl polyfill support for std::any, std::optional and std::variant now that the absl types are aliases of the std types 2025-05-19 absl-team Add UnpackStructImpl specialization for 23 struct members. 2025-05-19 absl-team Use static_cast instead of ImplicitCast_ for character conversions 2025-05-15 dmauro GoogleTest CI Update 2025-05-13 mkruskal Add [[nodiscard]] to GetParam() to prevent accidental misuse. 2025-05-12 absl-team Clarify that the return value of `InvokeArgument` is not the return value of the action. 2025-05-01 absl-team gtest: Remove incorrect documentation of private headers as PIMPL idiom 2025-04-30 dmauro Update documentation for v1.17.0 2025-04-30 dmauro Update GoogleTest dependencies in preparation for release 2025-04-29 lar Use std::memcpy instead of a union to access floating point bits. 2025-04-29 dmauro Fix GCC15 warning that <ciso646> is deprecated in C++17 2025-04-23 absl-team AllOf, AnyOf, Optional: Avoid generating unnecessary match explanations 2025-04-17 dmauro Bump RE2 dependency to 2024-07-02.bcr.1 2025-04-09 jacobsa `gmock-actions`: add a missing conversion operator to `WithArgsAction`. 2025-04-09 jacobsa `gmock-actions`: run clang-format. 2025-03-26 durandal Remove obsolete references to LinuxThreads. 2025-03-21 absl-team Add UnpackStructImpl for structs with 22 fields. 2025-03-21 ototot Fix a typo 2025-03-20 absl-team Add a non-'const' overload for the function invoked by the IgnoreArgs action wrapper. 2025-03-18 wan Improve the failure messages of `ElementsAre()`, `ElementsAreArray()`, etc. 2025-03-11 wan Clarify the polymorphic matcher concept and explain how to define a composite matcher. 2025-03-11 wan Allow `DistanceFrom()` to use user-defined `abs()` by default. 2025-03-07 wan Add a `DistanceFrom()` matcher for general distance comparison. 2025-03-04 absl-team Add a `testing::ConvertGenerator` overload that accepts a converting functor. This allows the use of classes that do not have a converting ctor to the desired type. 2025-02-28 dmauro Try to warn the user when test filters do not match any tests 2025-02-27 pizzud googletest: Add testonly alias of :gtest for testonly cc_libraries to use. 2025-02-27 absl-team Add UnpackStructImpl for structs with 21 fields. 2025-02-26 dmauro Output to the test warning file if no tests are linked. 2025-02-24 wan Adds support for a --gtest_fail_if_no_test_linked flag to fail the test program if no test case is linked in (a common programmer mistake). 2025-02-21 dmauro GoogleTest C++17 cleanups * Use `[[nodiscard]]` instead of GTEST_MUST_USE_RESULT_ * Use `[[maybe_unused]]` instead of GTEST_INTERNAL_ATTRIBUTE_MAYBE_UNUSED * Use `[[deprecated]]` instead of `GTEST_INTERNAL_DEPRECATED` * Remove `GTEST_INTERNAL_NEED_REDUNDANT_CONSTEXPR_DECL` 2025-02-17 jmr Property: Promote note to warning 2025-02-12 dmauro Require C++17 2025-02-10 absl-team Add SaveArgByMove 2025-02-07 dmauro Update docs for v1.16.x branch 2025-02-06 dmauro Update GoogleTest deps in preparation for release 2025-02-06 dmauro Remove empty glob pattern, which is now an error. 2025-01-31 absl-team Pull Regexp syntax out of Death test section in advanced.md 2025-01-31 absl-team Fix extended regular expressions reference URL in advanced.md 2025-01-30 absl-team Export testsuite properties as XML elements, not attributes. 2025-01-16 absl-team Cast mutable lvalue references to const from testing::ResultOf 2025-01-15 absl-team Enable safe matcher casts from `Matcher<const T&>` to `Matcher<T>`. 2025-01-10 hector.dearman Default to color output for ghostty 2025-01-09 absl-team Document unexpected interaction with death test error code and gmock. 2025-01-08 absl-team Add UnpackStructImpl for structs with 20 fields. 2024-12-26 absl-team gtest: Output a canned test case for test suite setup / teardown failures in XML/JSON 2024-12-23 absl-team Put the fake Fuchsia SDK in a module extension 2024-12-16 absl-team the public version already has the const qualifier 2024-12-11 absl-team Update the links to ISTQB glossary. 2024-12-10 absl-team Add support for printing C++20 std::*_ordering types to gtest. Adds feature test macro for C++20 <compare> header, a pretty-printer, and tests. Inexplicably, these types aren't enums, so can't be handled with a switch. 2024-11-15 andy.soffer Fix documentation bug. 2024-11-04 absl-team Fixing a typo in the documentation of IsSubsetOf(). 2024-10-31 absl-team Remove mention of using `ASSERT_...` statements inside custom matcher definitions. 2024-10-27 pbos Use FAIL() in GTEST_SKIP() documentation 2024-10-16 absl-team Avoid creating std::vector<const T> in UnorderedElementsAreArrayMatcher and others. 2024-10-14 absl-team This change adjusts how `ASSERT_NEAR` and `EXPECT_NEAR` treats infinity, such that `ASSERT_NEAR(inf, inf, 0)` passes. This makes the behavior more consistent with `ASSERT_EQ(inf, inf)` which succeeds. 2024-10-04 absl-team Automated Code Change 2024-10-01 absl-team Optional(): Add support for std::optional<>-like types lacking bool conversion. 2024-09-16 absl-team Use matcher's description in AnyOf when matcher has no explanation. 2024-08-29 absl-team Automated Code Change 2024-08-01 dmauro Update main to point to 1.15.2 patch release 2024-07-30 dmauro Remove auto-detection of Python toolchain from MODULE.bazel since it affects downstream users 2024-07-30 absl-team Directly include `gmock.h` and `gtest.h` in gmock-matchers tests. 2024-07-24 absl-team Use matcher's description in AllOf if matcher has no explanation. 2024-07-23 jacobsa gmock-actions: make DoAll convert to OnceAction via custom conversions. 2024-07-23 jacobsa Run clang-format. 2024-07-20 dmauro Change the Bazel build to use the canonical repo names used by Bzlmod and the Bazel Central Registry 2024-07-16 dmauro Update GoogleTest Bazel quickstart for Bzlmod 2024-07-16 dmauro Update main branch to reflect the release of 1.15.0 2024-07-16 absl-team Use matcher's description in AllOf if matcher has no explanation. 2024-07-15 absl-team Use matcher's description in AllOf if matcher has no explanation. Created with: roll-dep third_party/googletest/src Change-Id: I8352afc32791030187946292a2f5aca6fcc8a05a Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6897921 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Bug: 40249958 Change-Id: I44cac4484c5172f71f96699b6dc9e41e632f5fd8 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6909331 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Mark Foltz <mfoltz@chromium.org>
…6e8a8acb91a This picks up a couple *years* worth of BoringSSL changes. The main relevant change here is that generate_build_files.py is no longer needed! Everything it generated is now checked in BoringSSL proper, including a GN source list. $ git log 8d19c850d..26e8a8acb --date=short --no-merges --format='%ad %ae %s' 2025-08-22 davidben bssl-crypto: Fix Ed25519 SPKI parser to check key types 2025-07-09 agl Add a jitter entropy source. 2025-08-15 davidben Set an EVP_PKEY's algorithm and data together 2025-08-15 davidben Make some more half-empty EVP_PKEY states impossible 2025-08-14 davidben Limit EVP_PKEY_set_type to EVP_PKEY_X25519 2025-08-19 davidben Add a test that arbitrary curves can be wrapped in EVP_PKEY 2025-08-15 davidben Stop tracking an ENGINE in EVP_PKEY_CTX 2025-08-13 davidben Rename EVP_PKEY_METHOD to EVP_PKEY_CTX_METHOD 2025-08-15 davidben Pull the EC_GROUP_new_by_curve_name up into EVP_PKEY_CTX_set_ec_paramgen_curve_nid 2025-08-16 davidben Split evp_tests.txt into separate files 2025-08-16 davidben Add a test for SPKI and PKCS8 parsing with unknown algorithms 2025-08-20 chlily Fix markdown syntax in BUILDING.md 2025-08-17 davidben Test async BIO_flush and fix a corner case 2025-08-15 davidben Rename EVP_R_EXPECTING_AN_EC_KEY_KEY to match OpenSSL 2025-08-16 davidben Document the generators for all the MODP groups 2025-08-15 davidben Remove an old, impractical TODO 2025-08-15 davidben Say a bit more in docs about how to use EVP_PKEY_CTX 2025-08-18 davidben Bump version for BCR 2025-08-15 davidben Run through more code in PKCS#8 and SPKI parsers 2025-08-18 davidben Fix typo in comment 2025-08-17 davidben runner: Remove need for an AllCurves value 2025-08-14 davidben Remove redundant copy of EVP_PKEY type 2025-08-15 davidben Remove EVP_PKEY_print_* support for DSA 2025-08-15 davidben Don't support parameterless DSA keys in SPKIs 2025-08-15 davidben Add a couple more no-op compatibility functions 2025-08-14 davidben More consistently reset EVP_PKEYs in free_it 2025-08-14 davidben Unexport the Kyber implementation 2025-08-14 davidben Deprecate EVP_PKEY_set_type 2025-08-14 davidben Fix reference to public key in evp.h docs 2025-08-13 ellyjones pki: add PEMDecode and PEMDecodeSingle 2025-06-17 agl Switch to using a derivation function in CTR-DRBG. 2025-08-13 ellyjones pki: allow span<string_view> for allowed types in PEMTokenizer 2025-08-13 chlily Style guide: mention placement of & for reference types 2025-08-12 davidben Update releasing docs slightly 2025-08-12 chlily Implement MLKEM1024 for TLS 2025-08-06 agl delocate: support 4-bit tweak immediates for AArch64. 2025-08-08 davidben Add a discussion about callbacks to API Conventions 2025-06-17 agl Don't run CTR-DRBG in Kyber tests. 2025-08-07 agl Link to ACVP results for 20250728. 2025-08-07 davidben Bump Bazel deps and version for BCR 2025-08-05 chlily Expand BCM abbreviation in the FIPS.md documentation 2025-08-04 chlily Add IWYU export in nid.h file generated by objects.go 2025-08-04 chlily Fix documentation typo 2025-08-04 chlily Revert Rust config for 32-bit Linux CI/CQ bots 2025-08-04 chlily Run Rust recipe steps on Mac CI/CQ builders and 32-bit Linux 2025-07-31 chlily Run Rust recipe steps on "win64_rel" builder 2025-07-31 chlily Make Windows Rust try builder use a Release build 2025-07-29 chlily Add a default-off win64_rust try builder for testing 2025-07-28 chlily Run Rust recipe steps on "linux" builder 2025-07-28 agl Fix FIPS version number comment. (...) 2023-09-01 alex.gaynor Return the correct value in EVP_CIPHER_CTX_iv_length after EVP_CTRL_AEAD_SET_IVLEN 2023-06-01 yukl Add X25519 bindings for bssl-crypto 2023-06-01 yukl Add ecdh and P256 bindings to bssl-crypto 2023-09-01 davidben Update the warnings on split handshakes and handshake hints 2023-09-01 davidben runner: Check that the shim HRRs echo the session ID 2023-09-01 davidben Reland "Build with C11 on MSVC in the standalone Bazel build" 2023-08-31 yukl Fix cargo clippy and fmt 2023-08-17 scw delocate: accept more directive expressions 2023-08-29 davidben Initialize libunwind cursors from the signal handler's ucontext_t 2023-08-24 davidben Remove another decltype(fclose) 2023-08-28 davidben Save trampoline state in unwind tests more straightforwardly 2023-08-29 davidben Explicitly mark saved registers with .cfi_restore 2023-08-28 bbe Remove undesired OPENSSL_EXPORT's in non-library code 2023-08-28 davidben Fix RBP-based unwind in fiat assembly 2023-08-28 bbe Remove another OPENSSL_EXPORT in an enum 2023-08-24 davidben Silence warn_unused_result warning on write() call 2023-08-25 bbe Remove OPENSSL_EXPORT from enum in fillins/net_errors.h 2023-08-25 bbe Ensure OPENSSL_EXPORT is only on the class not methods. 2023-08-24 bbe Add pki file lists to generated gn build files 2023-06-05 nwadih Add Rust bindings to AES_CTR through EVP_* cipher API's 2023-08-24 davidben Export CBS/CBB unicode functions 2023-08-24 bbe rename fillins/string_util.h because gn is special 2023-08-24 bbe rename fillins/base64.c to handle gn being special 2023-08-24 davidben Also suppress OPENSSL_LINUX for nanolibc 2023-08-24 davidben Add BN_bn2lebinpad and BN_lebin2bn 2023-08-17 davidben Use a callable type for ScopedFILE in settings_writer.cc 2023-06-02 nwadih Add Rust bindings to AES-GCM through the EVP_AEAD_* APIs 2023-08-18 davidben Deduplicate the three copies of OBJ_cmp 2023-08-17 bbe Remove header file accidentally added to sources.cmake 2023-08-17 bbe Sync pki to chromium d740199e083b70d13506973c6f479f0b01165a05 2023-07-25 bbe Move the fuzzers into the fuzz directory and make them build. 2023-08-16 davidben Fix typo in .size directives for aesni_gcm_encrypt 2023-08-16 bbe Hook in ocsp into libpki, and run the ocsp unit tests. 2023-08-16 bbe Update pki to chromium cf9a08ff8be3a3f2d5b13693cc13ef22ab7ee618 2023-08-16 bbe Make a BSSL_CHECK that always aborts 2023-05-19 nwadih Add rust bindings to AES-GCM-SIV through the EVP_AEAD_* API's 2023-08-14 davidben Add EVP_HPKE_KEY_move 2023-08-11 davidben Default to q = (p-1)/2 for DH keygen 2023-08-15 davidben Remove the CRYPTO_is_*_capable_at_runtime indirection 2023-08-14 davidben Select SHA-256 vs SHA-512 explicitly in perlasm 2023-08-14 davidben Hash-to-curve is now RFC 9380 2023-08-14 bbe Add the rest of the new test data files to sources.cmake 2023-08-11 davidben Align DH keygen with NIST's formulation when q is available 2023-08-14 bbe add missing test file to sources.cmake 2023-07-27 davidben Consistently reject large p and large q in DH 2023-08-14 bbe use <errno.h> instead of <sys/errno.h> 2023-08-11 davidben Document and test DH_generate_key's weird key reuse behavior 2023-08-14 bbe Sync pki to chromium 8049b24a3fa617e66c5d3fc0e9322bb07c500f49 2023-07-31 bbe Add a basic sanity test for getentropy() if we are using it. 2023-07-20 yich Add ChromeOS EC related targets Created with: roll-dep third_party/boringssl/src Change-Id: Ibfb51bca122dc6ed2cffa76fe1d2a79e4a1e47fe Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6881127 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
Bug: 391445226 Change-Id: I16ee2a97fb106d2e2560991cd1bfbe92913949fa Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/6917871 Reviewed-by: Muyao Xu <muyaoxu@google.com> Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Taesun Yeoum <taesuny@google.com>
My local mac compiler is complaining about incorrect semicolon usage in the standalone sender code. This patch fixes the build by removing the extraneous semicolons. Change-Id: I87d33e48c59906fce203dfeacb37ab8cf57e1262 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7007553 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This patch cleans up the statistics defines file, changing the name to statistics common to more accurately represent its contents, and more tightly grouping related types and classes into the StatisticsEvent struct. This is helpful for the upcoming receiver statistics implementation. Bug: 448199360 Change-Id: I5bc6ee380b52c10fbe839de12844ba1b03eb58c9 Bypass-Check-License: moved a file. Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7008996 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This patch significantly refactors the ClockOffsetEstimator to improve the accuracy and stability of its network latency and clock offset estimations. The previous implementation used a simple weighted moving average, which was susceptible to jitter and slow to adapt to changing network conditions. The core of this change is the introduction of a 1D Kalman filter. This allows the estimator to: - More effectively smooth out network jitter, providing a more stable latency estimate. - Converge more quickly and accurately to the true latency and offset, even in the presence of noise. - Better track clock drift over time. To validate this new design, the unit test suite for the ClockOffsetEstimator has been greatly expanded to cover a wide range of realistic and challenging network scenarios, including: - High network jitter - Continuous clock drift - Bursty packet loss - Sudden, large latency spikes - A mix of audio and video media streams Additionally, a new general-purpose Gmock matcher, `EqualsDuration`, has been added to `testing/util` to provide more readable error messages for std::chrono::duration types in unit tests. Bug: b:448199360 Merge branch 'refactor-event' into clock_offset_estimator_refactor WIP refactor Change-Id: I7a3df074a7e421b051191dcbc9503a2b31dd6fea Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7007555 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
Replaces the ClockDriftSmoother's weighted-average logic with a more robust exponential moving average (EMA) filter. This provides more stable and predictable smoothing of the clock offset. This change also includes: - A new, comprehensive unit test suite for the ClockDriftSmoother. - A change to `ClockDriftSmoother::Current()` to return `std::optional` to make the uninitialized state explicit and improve call-site safety. - A new `ExpectDurationNear` test helper to simplify duration comparisons in tests, replacing the more verbose `EXPECT_THAT` with `EqualsDuration`. The `receiver.cc` implementation is updated to safely handle the optional return value from the smoother. Bug: 298085631 Change-Id: I9ae5816c6a6586bed99774a5b3ce21bd01f888be Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7032428 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
I recently installed Open Screen on my new laptop and wanted to update the build instructions. Change-Id: I9a77a15125d815ef7a3a1a9820ae15020876fe26 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7083713 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
Chromium has been building openscreen with C++20 for years now, this looks like a leftover. Bug: 388070065 Change-Id: Id03507d446d3dfccb4aa184a4fe4431daf978978 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7124721 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by: Jordan Bayles <jophba@chromium.org>
Context in the linked bug. See also https://crrev.com/c/7123796 for the recipe-side change. Bug: 458361503 Change-Id: I986d780ffe35ed0f8c975de63de85eb16cdba4b8 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7128379 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This reverts commit df86628. Reason for revert: CQ is nuked because there are no Ubuntu 24 bots in the pool https://ci.chromium.org/ui/p/openscreen/builders/try/linux_x64_gcc/b8698900705016156929/overview Original change's description: > Upgrade linux bots from Ubuntu 22.04 to Ubuntu 24.04 > > Context in the linked bug. See also https://crrev.com/c/7123796 > for the recipe-side change. > > Bug: 458361503 > Change-Id: I986d780ffe35ed0f8c975de63de85eb16cdba4b8 > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7128379 > Reviewed-by: Jordan Bayles <jophba@chromium.org> > Commit-Queue: Jordan Bayles <jophba@chromium.org> Bug: 458361503 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I0b8ad4ffcca5928f62b01d22f07ec0c240990c30 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7130840 Commit-Queue: Mark Foltz <mfoltz@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Mark Foltz <mfoltz@chromium.org>
This patch updates the external libraries documentation and adds a shared `lib` target. Change-Id: Ica21fe6b24554bfed188a90b0505edefc39c1c0d Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7128112 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Muyao Xu <muyaoxu@google.com>
A message from an internal linter (cl/828751989): proto2::MessageLite::ParseFromArray has been deprecated. Change-Id: I7c8388d73e0dfee850fcbe39f8140d436a85a3d7 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7128520 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Taesun Yeoum <taesuny@google.com> Reviewed-by: Jordan Bayles <jophba@chromium.org>
Attempting to roll //build currently fails on Mac because crrev.com/c/6493969 enforced the SDK version to be >= 15 and the bots only have SDK 14 [1]. In fact the bots are Mac-13 and the minimum Mac version to support SDK 15 is Mac 13.5 [2]. Let's upgrade the bots to Mac 15 and hope the default SDK version in them is enough to fix the error. I verified there are 7 Mac 15 machines in the flex pool. If this is still not enough, I will configure an explicit SDK version in a follow-up CL. [1] https://ci.chromium.org/ui/p/openscreen/builders/try/mac_x64/b8698563814246822177/overview [2] https://developer.apple.com/support/xcode/ Bug: 388070065 Change-Id: If62ddeceba3210f460c8ac91e3961177dedca89d Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7138041 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This is a reland of commit df86628 The original CL was reverted because there were no Ubuntu 24 bots in the flex pool. New bots were added in crrev.com/i/8748036. Original change's description: > Upgrade linux bots from Ubuntu 22.04 to Ubuntu 24.04 > > Context in the linked bug. See also https://crrev.com/c/7123796 > for the recipe-side change. > > Bug: 458361503 > Change-Id: I986d780ffe35ed0f8c975de63de85eb16cdba4b8 > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7128379 > Reviewed-by: Jordan Bayles <jophba@chromium.org> > Commit-Queue: Jordan Bayles <jophba@chromium.org> Bug: 458361503, 459541007 Change-Id: I7bac5ace54111f2c12cf13f851dbb429400e8440 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7131921 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This change enhances debugging capabilities by adding stack trace information to fatal error logs. When OSP_DCHECK_IS_ON() is enabled, a backtrace will be captured and symbolized, providing immediate insight into the call stack leading to a crash. This significantly speeds up diagnosis and resolution of critical bugs in debug builds. Bug: 448199360 Change-Id: Ic9419058b00d2e16df89fa31a759b839b9abc7c7 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7140298 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This change modifies the simulated capturer to use a fixed 10ms capture duration instead of a non-deterministic `now_()`. This improves the reliability and repeatability of simulations and tests by ensuring consistent timing behavior. Bug: 448199360 Change-Id: I5aabe426cd8301cc870817ad2336aa1e40a01025 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7140299 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Muyao Xu <muyaoxu@google.com>
I forgot to regenerate the .cfg files in https://crrev.com/c/7138041, so Mac bots didn't actually get updated. Change-Id: I8332335f217dd516ea2f25be42ccb3e377532fb5 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7141480 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
For convenience of review, patchset 1 purely copies third_party/protobuf and tools/protoc_wrapper/protoc_wrapper.py from an up-to-date Chromium checkout (while also fixing third_party/.gitignore so that protobuf code is properly checked into the repo). The interesting diff is composed by the remaining patchsets, which fix build errors. In particular this requires rolling abseil and quiche. Diff: https://chromium-review.googlesource.com/c/openscreen/+/7124727/1..14 Blamelists: https://quiche.googlesource.com/quiche/+log/5a433bd7de22c23700d046346bd3d3afe5c9cd07..810b9a7bc88326591de298c381ab2cf92037768f https://chromium.googlesource.com/chromium/third_party/instrumented_libraries/+log/3cc43119a29158bcde39d288a8def4b8ec49baf8..69015643b3f68dbd438c010439c59adc52cac808 https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/dd4c89bd657f1e247ce5111a5c89ffe6ccfd0c92..987c57f325f7fa8472fa84e1f885f7534d391b0d https://chromium.googlesource.com/external/github.com/protocolbuffers/protobuf/+log/fe271ab76f2ad2b2b28c10443865d2af21e27e0e..a79f2d2e9fadd75e94f3fe40a0399bf0a5d90551 NO_IFTTT=Spurious warnings due to iftt within protobuf Bug: 388070065 Change-Id: Id12de58599922f60e5e74e384accb78ab14738a4 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7124727 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This patch removes use of our standalone bucket, since it is being audited and we also don't really need it. Bug: 458097717 Change-Id: Ic5f33c98eb181690eb687ae93751cb136a299de1 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7140019 Reviewed-by: Muyao Xu <muyaoxu@google.com>
This commit introduces the foundational elements for receiver-side event logging. It centralizes the `kCastName` constant, enables handling of the new `kReceiverLog` RTCP subtype, and adds the necessary infrastructure within `CompoundRtcpBuilder` to construct and send these log messages. Furthermore, it integrates the `are_receiver_event_logs_enabled` flag into `SessionConfig` and `OfferMessages`, allowing for negotiation of this feature during session setup. Bug: 448199360 Change-Id: I648e8c1d071c1865057769e229ab3b406de3fedb Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7140300 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Muyao Xu <muyaoxu@google.com>
There are no Mac-15 bots with x86_64, only arm64. Change-Id: Id99a6b90251ee43a7b506c82f230d75a94d17201 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7141959 Reviewed-by: Jordan Bayles <jophba@chromium.org>
These bots are arm64 now. No-Try: true Change-Id: I6e4969b57476ac88d11be5a1f2a4498d122dcd50 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7142899 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This patch fixes my local build (and probably just a configuration that is not currently built on the bots) by adding a few missing protobuf related files, following steps listed in the protobuf readme file: ``` third_party/protobuf/README.chromium ``` Bug: 388070065 Change-Id: I16735ba7dde7da5dd550949a876094f540187f5a Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7144609 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This patch fixes an Android build bug due to backtrace() not being available on the targeted version of Android. The solution is just disabling backtraces on Android. Change-Id: Iea817622e679447545a16e1161989954a219c582 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7144610 Reviewed-by: Muyao Xu <muyaoxu@google.com>
This commit implements the core logic for gathering and reporting receiver-side statistics. It integrates `RtpTimeTicks` into `SDLPlayerBase` for accurate playout event reporting, and adds the `ReportPlayoutEvent` interface to `ReceiverBase`. The `Receiver` class is updated to collect packet received, frame ACK, and frame played out events, which are then sent via RTCP log messages. Furthermore, the `StatisticsAnalyzer` is refined to leverage a dedicated clock offset estimator for network latency, improving the accuracy of statistics. Extensive unit tests are added to verify the correctness of the new statistics gathering and reporting mechanisms. Bug: 448199360 Change-Id: I5a9b7dd98ac26bd4bff20cb1adc02ccf18092b45 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7140301 Reviewed-by: Muyao Xu <muyaoxu@google.com> Commit-Queue: Jordan Bayles <jophba@chromium.org>
These are too important, it's best to make them explicit. Also fix the _CheckGeneratedInfraFiles presubmit check I added when CQ was completely busted. It should use PresubmitPromptWarning, not PresubmitWarning. Bug: None Change-Id: I81a3f77f64068173d913b43796485c49caccfc89 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7153638 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
This is needed to unblock rolling //build. Change-Id: I15f686c47523e63bd91c569d87bf519d926eb7ab Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7153718 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com>
…ing" This reverts commit ea12400. Reason for revert: Causing Linux-UBSan test failures https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/11642/overview Original change's description: > Feat: Implement receiver-side statistics gathering and reporting > > This commit implements the core logic for gathering and reporting > receiver-side statistics. It integrates `RtpTimeTicks` into > `SDLPlayerBase` for accurate playout event reporting, and adds the > `ReportPlayoutEvent` interface to `ReceiverBase`. The `Receiver` > class is updated to collect packet received, frame ACK, and frame > played out events, which are then sent via RTCP log messages. > > Furthermore, the `StatisticsAnalyzer` is refined to leverage a > dedicated clock offset estimator for network latency, improving the > accuracy of statistics. Extensive unit tests are added to verify the > correctness of the new statistics gathering and reporting mechanisms. > > Bug: 448199360 > Change-Id: I5a9b7dd98ac26bd4bff20cb1adc02ccf18092b45 > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7140301 > Reviewed-by: Muyao Xu <muyaoxu@google.com> > Commit-Queue: Jordan Bayles <jophba@chromium.org> Bug: 448199360 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I11d7833c7f6c3ed285f02adb2b3b22bf7f5a3de5 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7154239 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Jiacheng Guo <gjc@google.com> Commit-Queue: Jiacheng Guo <gjc@google.com>
…ing" This reverts commit 619fcbf. Reason for revert: fixed bound error. Original change's description: > Revert "Feat: Implement receiver-side statistics gathering and reporting" > > This reverts commit ea12400. > > Reason for revert: Causing Linux-UBSan test failures > https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/11642/overview > > Original change's description: > > Feat: Implement receiver-side statistics gathering and reporting > > > > This commit implements the core logic for gathering and reporting > > receiver-side statistics. It integrates `RtpTimeTicks` into > > `SDLPlayerBase` for accurate playout event reporting, and adds the > > `ReportPlayoutEvent` interface to `ReceiverBase`. The `Receiver` > > class is updated to collect packet received, frame ACK, and frame > > played out events, which are then sent via RTCP log messages. > > > > Furthermore, the `StatisticsAnalyzer` is refined to leverage a > > dedicated clock offset estimator for network latency, improving the > > accuracy of statistics. Extensive unit tests are added to verify the > > correctness of the new statistics gathering and reporting mechanisms. > > > > Bug: 448199360 > > Change-Id: I5a9b7dd98ac26bd4bff20cb1adc02ccf18092b45 > > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7140301 > > Reviewed-by: Muyao Xu <muyaoxu@google.com> > > Commit-Queue: Jordan Bayles <jophba@chromium.org> > > Bug: 448199360 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: I11d7833c7f6c3ed285f02adb2b3b22bf7f5a3de5 > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7154239 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Jiacheng Guo <gjc@google.com> > Commit-Queue: Jiacheng Guo <gjc@google.com> Bug: 448199360 Change-Id: I569a34144c1646fe852d5a070c0e51ce298d410a Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7156913 Reviewed-by: Muyao Xu <muyaoxu@google.com>
`led` is a tool that allows testing infra changes ahead of submission. It needs dedicated setup, handled by this CL. No-Try because the mac bot is broken. No-Try: true Change-Id: Ic37d701dc8e887eac092678c878eafe084444cb3 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7157554 Reviewed-by: Jordan Bayles <jophba@chromium.org>
Format one BUILD.gn file, and avoid a false positive from checkdeps.py Change-Id: I52398fff63e9bda4b2f5bd658c3ff0b4fb51e28b Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7169123 Reviewed-by: Jordan Bayles <jophba@chromium.org>
gn, buildtools, build, this_party/jsoncpp, quiche, libfuzzer, libc++, libc++abi, llvm-libc, googleurl and clang. This roll required replacing use of src/tools/clang/scripts/update.py with explicit GCS dependencies (like chromium/src does), in order to fetch llvm-otool for Mac. * https://gn.googlesource.com/gn.git/+log/487f8353f154..c5a0003bcc2a * https://chromium.googlesource.com/chromium/src/buildtools/+log/077a66f30fcf..5df641722f2e https://chromium.googlesource.com/chromium/src/build/+log/526c6cbd6a32..371ecb089d9 * https://chromium.googlesource.com/external/github.com/open-source-parsers/jsoncpp/+log/89e2973c754a9c02a49974d839779b151e95afd6..9af09c4a4abe5928d1f7a6e7ec1c73a565bb362e * https://quiche.googlesource.com/quiche/+log/810b9a7bc88326591de298c381ab2cf92037768f..2b80e306994b02b4bdb067166960d3550fcb9430 * https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt/lib/fuzzer/+log/e31b99917861f891308269c36a32363b120126bb..bea408a6e01f0f7e6c82a43121fe3af4506c932e * https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx/+log/11c38d901d29bc91aee3efb53652f7141f72f47f..454a561737fb62e75ba82bfae9fb07ee64acdd68 * https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/83dfa1f5bfce32d5f75695542468e37ead8163b8..de02e5d57052b3b6d5fcd76dccde9380bca39360 * https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc/+log/2222607a3ea3d5f65338d3b36a4cc5fb563169ab..74b25173cba70124bff5da97cc339d90c516c5f6 * https://quiche.googlesource.com/googleurl/+log/dfe8ef6164f8b4e3e9a9cbe8521bb81359918393..94ff147fe0b96b4cca5d6d316b9af6210c0b8051 Bug: None Change-Id: Ifbad25f82f898f0cf5a096f45c4867a8f7397ba7 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7116905 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org>
This reverts commit bb51ae1. Reason for revert: following crrev.com/c/7171485, openscreen should be able to rely on the default xcode version of the bots Original change's description: > Update to Xcode 26 in Mac bots > > This is needed to unblock rolling //build. > > Change-Id: I15f686c47523e63bd91c569d87bf519d926eb7ab > Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7153718 > Reviewed-by: Jordan Bayles <jophba@chromium.org> > Commit-Queue: Victor Vianna <victorvianna@google.com> Bug: 461757070 Change-Id: I089d67c22c22a92d9eff5fec6c92535b5b45d212 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7177781 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jordan Bayles <jophba@chromium.org>
…minated. R=martinduke@google.com Change-Id: I871285c3d0f87b168e39c71b7a1971cae2696ca7 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7179540 Commit-Queue: Mark Foltz <mfoltz@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org>
Added revision 9059f5cad030ba11d37818847443a53918c327b1. Commands run to determine revision: cd jsoncpp && git rev-parse 1.9.4 Bug: 460543159 Change-Id: Idf8bc327357c2cff6f6e7e5c2bc5a93225eaae42 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7154241 Commit-Queue: Jordan Brown <rop@google.com> Reviewed-by: Muyao Xu <muyaoxu@google.com> Owners-Override: Jordan Brown <rop@google.com> Reviewed-by: Jiewei Qian <qjw@chromium.org>
https://chromium.googlesource.com/chromium/src/build/+log/371ecb089d96..f2bcd9276005 $ git log 371ecb089..f2bcd9276 --date=short --no-merges --format='%ad %ae %s' 2025-11-26 wnwen android: Update docs to use ChromePublic/Trichrome 2025-11-26 zijiehe [fuchsia] Move permission control to web_engine_config 2025-11-26 tikuta build: Do not include buildtools directory in clang modules build 2025-11-25 chromium-internal-autoroll Roll Fuchsia Internal Images from 30.20251118.102.1 to 30.20251125.103.1 2025-11-25 msta Write a script to analyze the amount of time spent #including each file. 2025-11-25 ajgo Delayload iphlpapi & dhcpcsvc 2025-11-25 justincohen ios: Enforce EarlyMallocZoneRegistration load order in Chrome 2025-11-21 gulfem [build] Balanced partitioning for section ordering 2025-11-21 agrieve Revert "build: Speed up JUnit test listing" 2025-11-21 victorvianna [build] Remove use_cxx17 support 2025-11-21 victorvianna [build] Allow other repos to control use_cxx23 with build_overrides 2025-11-21 pkaplan wrap the privileged helper executable identifier string in quotes 2025-11-21 jmarc Enable checking system_headers for windows compile. 2025-11-21 zequanwu Reland "Roll clang+rust llvmorg-22-init-12326-g8a5f1533-2 : llvmorg-22-init-14273-gea10026b-1 / ab925646fae038b02bd462cd328ae9eef1639236-1 : 11339a0ef5ed586bb7ea4f85a9b7287880caac3a-1" 2025-11-21 luci-bisection Revert "Roll clang+rust llvmorg-22-init-12326-g8a5f1533-2 : llvmorg-22-init-14273-gea10026b-1 / ab925646fae038b02bd462cd328ae9eef1639236-1 : 11339a0ef5ed586bb7ea4f85a9b7287880caac3a-1" 2025-11-20 ukai mitigate codesearch-gen-chromium-fuchsia 2025-11-20 msta Write a script to generate a database of performance metrics. 2025-11-20 wnwen build: Speed up JUnit test listing 2025-11-20 ollel Disable sanitizer in gn instead of passing around an ignorelist 2025-11-20 thestig Include <features.h> directly in build_config.h on Linux 2025-11-20 agrieve Android: Suppress androidx roll tracereferences failure 2025-11-20 wnwen android: Use merged manifest for lint targets 2025-11-19 msta Fix some minor issues with the run_action benchmark. 2025-11-19 victorvianna Add autoconf to install-build-deps.py 2025-11-19 drubery Fix line-ending in build/config/fuchsia/gn_configs.gni 2025-11-19 beainsa [TDR] Remove TODOs linked to issue 40616187. 2025-11-19 wnwen build: Move Android lint target from bundle to apk 2025-11-19 zbikowski Remove old-style Android ARM64 PGO profile roller artifacts 2025-11-18 jwata build: forward configs to compiled_action_foreach 2025-11-18 jmarc Fix the hardcoded -MMD compile command on Mac. 2025-11-18 msta Add a tool to benchmark the speed of building a specific file locally. 2025-11-18 zijiehe [fuchsia] Update default Fuchsia target API level to 29 2025-11-18 chromium-internal-autoroll Roll Fuchsia Internal Images from 30.20251110.103.1 to 30.20251118.102.1 2025-11-18 agrieve Android: Change default target_cpu from "arm" to "arm64" Created with: roll-dep build R=jophba@chromium.org Change-Id: If7c213b47a3fb61b3eaee1f8f568db6f5ac0379d Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7206857 Reviewed-by: Jordan Bayles <jophba@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
Openscreen generally has the same consumers as WebRTC. So while WebRTC stays in C++20, so should openscreen. Bug: 388070065 Change-Id: If7ed4b5beaa59999377a74b4acd362d7a18de993 Reviewed-on: https://chromium-review.googlesource.com/c/openscreen/+/7225673 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by: Jordan Bayles <jophba@chromium.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hack to get commit notifications. Do not close!!!