Fixed AirbrakeAppender for Grails 3.1.4 > *#44
Fixed AirbrakeAppender for Grails 3.1.4 > *#44MarcAtRiflmedia wants to merge 1 commit intocoderberry:grails-3.0from
Conversation
| class AirbrakeStackTraceFilterer extends DefaultStackTraceFilterer{ | ||
|
|
||
|
|
||
| private static final String[] DEFAULT_INTERNAL_PACKAGES = [ |
There was a problem hiding this comment.
where did this list come from?
There was a problem hiding this comment.
It comes from the original org.grails.exceptions.reporting.DefaultStackTraceFilterer.
This list + packagesToFilter arraylist can probably be removed here.
|
I like it and we should figure out how to merge it. A few comments on the diffs that would be good to understand. Also can we squash the commits? There is a lot of churn and its hard to review what the final set of changes looks like. Lastly is there a reason to require Grails 3.1.4? Can we just be 3.x? |
|
You can do whatever you want. No problem. I have not tested with versions below 3.1.4 but i guess it could work with any 3.1.x or 3.x... Need to try. |
|
Can you please do the interactive rebase to squash all the commits and then force push the single commit? Github does the right thing in that situation. |
MarcAtRiflmedia
force-pushed
the
grails-3.1.4
branch
from
060c611 to
426c5fa
Compare
|
I guess that's done now. |
| ## Release Notes | ||
|
|
||
| * 1.0.2 - 2016/04/11 | ||
| * Fix AirbrakeAppender for Grails 3.1.4. |
There was a problem hiding this comment.
do we need to minor releases?
There was a problem hiding this comment.
I guess not necessarily
| } | ||
| title = "Airbrake-3.1" | ||
| desc = "Grails Airbrake plugin compatible with version 3.1.4 > *" | ||
| developers = [marcatriflmedia:"Marc-Emmanuel Ramage"] |
There was a problem hiding this comment.
The publish config can be removed/replaced... It was for my own usage only.
|
Have we removed the old Grails 2.x code too? |
2 participants
No description provided.