Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add order parameter in events get request #215

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

danielsp45
Copy link
Member

No description provided.

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for coderdojobraga-maintenance canceled.

Name Link
🔨 Latest commit 159342d
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-maintenance/deploys/6570ff8b9fae220008f0af87

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for coderdojobraga-web canceled.

Name Link
🔨 Latest commit 159342d
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-web/deploys/6570ff8bbe1d3400081e9d52

Copy link

reviewpad bot commented Dec 6, 2023

AI-Generated Summary: This pull request introduces an order parameter to the useEvents function in useEvents.tsx. The order parameter is used to sort the events when fetching them with API.get. This will allow consumers of the function to specify the order of the events fetched from the API. Subsequently, the useEvents function call in events.js is updated to pass the 'desc' argument to the order parameter to sort the events in descending order. This change is reflected in 2 files, namely, useEvents.tsx and events.js.

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for coderdojobraga-app ready!

Name Link
🔨 Latest commit 159342d
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-app/deploys/6570ff8b5a4b150008babc80
😎 Deploy Preview https://deploy-preview-215--coderdojobraga-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for coderdojobraga-blog canceled.

Name Link
🔨 Latest commit 159342d
🔍 Latest deploy log https://app.netlify.com/sites/coderdojobraga-blog/deploys/6570ff8b24ee10000832b036

Copy link
Member

@pedrofp4444 pedrofp4444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, it is a small change that improves a lot the user experience! 💪

@danielsp45 danielsp45 merged commit 529320f into main Jan 9, 2024
19 checks passed
@danielsp45 danielsp45 deleted the dp/add-order-parameter branch January 9, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app App related contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants