You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR intends to improve the entire user experience of the target audience (Guardians). I moved the editing and creation of Ninjas from new pages to a single modal that keeps the route in use. I also standardized the Ninjas page to match the rest of the application with "default" components. At this point, it is still necessary to correct the "invalid date" in the Ninjas edition, which arises from the fact that the .birthday property is not included in the response data. I'm awaiting correction from the backend to make the changes fully functional.
AI-Generated Summary: This pull request refactors the "Ninjas" page to enhance usability. Changes are made in three files, with net 167 insertions and 101 deletions. The update includes improvements in how user interaction with the "Edit" option behaves in the "Ninja" component, replacing the previous Link-based approach with a state-based method utilizing React's useState hook to show a form based on user confirmation. Additionally, significant changes are made in the "NinjaForm" component, introducing a modal instead of a switching page for creating or editing a Ninja's data. Meanwhile, the "ninjas" page has seen additions related to state management and fetch methods for better UX during Ninja creation.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reviewpad
bot
requested review from
Afonso-santos,
afonsopimenta,
danielsp45,
diogogmatos,
EnzoVieira,
ruilopesm and
ruioliveira02
This PR intends to improve the entire user experience of the target audience (Guardians). I moved the editing and creation of Ninjas from new pages to a single modal that keeps the route in use. I also standardized the Ninjas page to match the rest of the application with "default" components. At this point, it is still necessary to correct the "invalid date" in the Ninjas edition, which arises from the fact that the .birthday property is not included in the response data. I'm awaiting correction from the backend to make the changes fully functional.