Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop animations #223

Open
wants to merge 75 commits into
base: main
Choose a base branch
from
Open

Drag and drop animations #223

wants to merge 75 commits into from

Conversation

bryce-oc
Copy link
Collaborator

@bryce-oc bryce-oc commented Feb 2, 2022

Change Summary

[Briefly summarise the changes that you made. Just high-level stuff]

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

peter-tanner and others added 30 commits December 4, 2021 14:44
…proper height, made basic draggable scalable
- Added hover scale transitions to draggable characters.
…oat when they are no longer being hovered on.
… when dragged, refactored hover zoom to work with wiggle.
… further animations, and changed image size to fit.
…component devolved childrens styling and had to be forced back into relative positioning
…codersforcauses/foodbank into update-simple-drag-and-drop-foodgroupV2
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.


return (
<>
<Image
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative (alt attribute). This is a problem for people using screen readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants