Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add pre-commit workflow #3284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdeweerd
Copy link
Contributor

This runs the pre-commit setup in a github workflow that will also annotate the PRs.

@larsoner
Copy link
Member

I think inline comments are neat but I'm worried about adding a bunch of new infrastructure that we need to maintain. Ideally contributors would pre-commit install --install-hooks locally and see the errors. And if they don't do that, then click the "details" button on the failed CI.

@mdeweerd
Copy link
Contributor Author

Seeing the annotation in context is IMHO more efficient, not just neat.
If the annotations break in the future, the related steps can just be disabled/commented/removed.

Annotations are fairly new - I think that we'll see more features coming in the github ui. I suppose that at some point in time an annotation can be turned into an issue in the UI - something that I do not expect in the textual report/details view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants