Updates events page. #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts to organise from the end user
sumit4613
changed the title
|
@paurushofficial please list the changes here, also make the title as concise as you can. |
sumit4613
requested changes
Aug 7, 2020
events/forms.py
Outdated
|
|
||
|
|
||
| class ParticipantForm(ModelForm): | ||
| class Meta: | ||
| model = EventParticipant | ||
| fields = ['title', 'student_name', | ||
| 'email_id', 'mobile_number', 'roll_no', 'branch'] | ||
|
|
||
| class requestEventForm(ModelForm): |
There was a problem hiding this comment.
Issues here :
- You're not following PEP8 conventions here.
- According to PEP8 there should be 2 blank lines after a class.
- Whenever you create class, it should be in caps. eg.
class RequestEventForm(ModelForm) - Also try to include docstrings in your class/methods.
events/models.py
Outdated
| @@ -53,3 +53,13 @@ class EventParticipant(TimeStampedModel): | |||
|
|
|||
| def __str__(self): | |||
| return self.student_name | |||
|
|
|||
| class requestEvent(models.Model): | |||
There was a problem hiding this comment.
- Here also, In classes, you should follow
CamelCasenotation. - Try to add docstrings to explain what the class/method is doing.
- You can also add docstrings for existing classes/methods.
events/views.py
Outdated
Comment on lines
12
to
14
| #numberOfEvents = len(events) | ||
| #if (numberOfEvents) == 0: | ||
| # events = 0 |
There was a problem hiding this comment.
Why did you left commented code here. You should remove the unused code.
events/views.py
Outdated
Comment on lines
52
to
64
| def requestEvent(request): | ||
| if request.method == 'POST': | ||
| form = requestEventForm(request.POST) | ||
| if form.is_valid(): | ||
| form.save() | ||
| your_name = form.cleaned_data.get('your_name') | ||
| title = form.cleaned_data.get('title') | ||
| messages.success( | ||
| request, f'Thank you { your_name } for requesting to organise { title }, you will be contacted shortly!') | ||
| return redirect('homepage') | ||
| else: | ||
| form = requestEventForm() | ||
| return render(request, 'event_register.html', {'form': form}) |
There was a problem hiding this comment.
While creating methods, you should not write like this.
Use this notation, def request_event(request):
|
This pull request introduces 1 alert when merging d0fe5cf into a8904e0 - view on LGTM.com new alerts:
|
|
@paurushofficial Sorry for being this late on replying to your PR. Could you please share some screenshots so that I can see it's working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nts to organise from the end user