-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: optimizing parameters sizing #207
base: master
Are you sure you want to change the base?
Conversation
42b979e
to
7e69a3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for fixing this @AuHau!
@markspanbroek I did more optimisations, could you please re-review? Since I will be going over |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good @AuHau!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, Adam. It's a long overdue change.
Agree with Mark's comment on changed requestEnd
. And two other function signature updates (both _slotPayout
overloads).
Will approve as these are small changes.
ea30fbd
to
d99a897
Compare
Ready to merge @AuHau ? |
No, there is no |
968d846
to
4740c86
Compare
Co-authored-by: markspanbroek <mark@spanbroek.net>
4740c86
to
93fece8
Compare
I ran into yet another instance where we were using
uint256
for a time interval (duration, expiry, etc.), which does not make sense and makes working with these parameters in nim-codex more annoying, so my patience ran out, and I scaled down all the time relevant params touint64
. And since I was at it, I also started to look into others likeslotSize
andslots
. I scaled those touint64
as well. Theslots
(eq. number of slots in storage request) is IMHO fine havinguint64
, but theslotSize
gives us 16 exabytes, which is IMHO also fairly alright.I would like to point out, that with these changes and the reshuffling of the order in
Ask
we are saving 3xuint256
, as the 4*uint64
will fit into one "word" (eq.uint256
).Let me know what you think about these changes ;-)