Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty slug when user update profile #330

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Allow empty slug when user update profile #330

merged 2 commits into from
Jan 7, 2024

Conversation

Jadepypy
Copy link
Collaborator

@Jadepypy Jadepypy commented Jan 6, 2024 •
edited
Loading

Issue: #257

image

@Jadepypy Jadepypy mentioned this pull request Jan 6, 2024
Closed
@Jadepypy Jadepypy marked this pull request as draft January 6, 2024 09:36
@Jadepypy Jadepypy marked this pull request as ready for review January 6, 2024 10:11
@Jadepypy Jadepypy requested a review from MrOrz January 6, 2024 10:12
@MrOrz MrOrz linked an issue Jan 7, 2024 that may be closed by this pull request
Should allow clearing slug (UpdateUser with empty slug) #257
Closed
MrOrz
MrOrz approved these changes Jan 7, 2024
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have checked the related logic in rumors-site's ProfilePage and feel that the logic should work.

@MrOrz MrOrz merged commit 0af3829 into master Jan 7, 2024
2 checks passed
@MrOrz MrOrz deleted the allow-empty-slug branch January 7, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should allow clearing slug (UpdateUser with empty slug)
2 participants
@Jadepypy @MrOrz