Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10 - ContainedBy Property Bug #11

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Fix #10 - ContainedBy Property Bug #11

merged 3 commits into from
Oct 22, 2024

Conversation

Tw1sm
Copy link
Collaborator

@Tw1sm Tw1sm commented Oct 22, 2024

With the current main branch (version 0.4.0) when I upload a set of parsed results, I'm seeing these errors related to the ContainedBy attribute (#10). It does not appear to always be fatal, but in other cases I've seen BHCE/BHE fail to ingest 1+ JSON file due to it.

bloodhound-1  | {"level":"error","time":"2024-10-22T14:37:24.950684756Z","message":"Error decoding ein.User object: json: cannot unmarshal array into Go struct field User.ContainedBy of type ein.TypedPrincipal"}
bloodhound-1  | {"level":"error","time":"2024-10-22T14:37:24.950716298Z","message":"Error reading ingest file /opt/bloodhound/work/tmp/bh3374202504: json: cannot unmarshal array into Go struct field User.ContainedBy of type ein.TypedPrincipal"}
bloodhound-1  | {"level":"error","time":"2024-10-22T14:37:24.959774548Z","message":"Error decoding group object: json: cannot unmarshal array into Go struct field Group.ContainedBy of type ein.TypedPrincipal"}
bloodhound-1  | {"level":"error","time":"2024-10-22T14:37:24.959798381Z","message":"Error decoding group object: json: cannot unmarshal array into Go struct field Group.ContainedBy of type ein.TypedPrincipal"}
bloodhound-1  | {"level":"error","time":"2024-10-22T14:37:24.959806964Z","message":"Error decoding group object: json: cannot unmarshal array into Go struct field Group.ContainedBy of type ein.TypedPrincipal"}
bloodhound-1  | {"level":"error","time":"2024-10-22T14:37:24.959813423Z","message":"Error decoding group object: json: cannot unmarshal array into Go struct field Group.ContainedBy of type ein.TypedPrincipal"}

With this PR branch and the same log data, none of those errors now appear.

@Tw1sm Tw1sm linked an issue Oct 22, 2024 that may be closed by this pull request
@Tw1sm Tw1sm merged commit c837f2a into main Oct 22, 2024
3 checks passed
@Tw1sm Tw1sm deleted the fix/containedby branch October 22, 2024 15:13
Tw1sm added a commit that referenced this pull request Dec 17, 2024
* set containedby to empty dict by default for output JSON

* add table for blog links

* version & changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContainedBy Property Bug
1 participant