[NEAT-745] 🫵 feat; Support setting reference model directly #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
doctrino
commented
Feb 7, 2025
•
doctrino
commented
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
doctrino
commented
Feb 7, 2025
Comment on lines
+94
to
+117
| if include_reference is not False: | ||
| if include_reference is True and self._state.last_reference is not None: | ||
| ref_rules: InformationRules | DMSRules | None = self._state.last_reference | ||
| elif include_reference is True: | ||
| ref_rules = None | ||
| else: | ||
| if not self._state.client: | ||
| raise NeatSessionError("No client provided!") | ||
| ref_rules = None | ||
| with catch_issues() as issues: | ||
| ref_read = DMSImporter.from_data_model_id(self._state.client, include_reference).to_rules() | ||
| if ref_read.rules is not None: | ||
| ref_rules = ref_read.rules.as_verified_rules() | ||
| if ref_rules is None or issues.has_errors: | ||
| issues.action = f"Read {include_reference}" | ||
| return issues | ||
| if ref_rules is not None: | ||
| prefix = "Ref" | ||
| reference_rules_with_prefix = self._state.last_reference, prefix | ||
| if ( | ||
| isinstance(ref_rules.metadata, DMSMetadata) | ||
| and ref_rules.metadata.as_data_model_id() in COGNITE_MODELS | ||
| ): | ||
| prefix = "CDM" | ||
| reference_rules_with_prefix = ref_rules, prefix |
There was a problem hiding this comment.
This is something very special for writing to Excel, so kept the logic here.
doctrino
commented
Feb 7, 2025
| @@ -35,17 +39,18 @@ def __init__(self, state: SessionState, verbose: bool) -> None: | |||
| def excel( | |||
| self, | |||
| io: Any, | |||
| include_reference: bool = True, | |||
| include_reference: bool | DataModelIdentifier = True, | |||
There was a problem hiding this comment.
I think this is small feature which does not have to be behind an alpha flag.
nikokaoja
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.