test(react-components) Unit test for UndoManager #5028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilscognite
commented
Mar 6, 2025
| @@ -82,12 +82,6 @@ export class RevealRenderTarget { | |||
| options?: RevealRenderTargetOptions | |||
| ) { | |||
| this._viewer = viewer; | |||
|
|
|||
| const cameraManager = this.cameraManager; | |||
There was a problem hiding this comment.
This is not needed and will give problems in the unit test
| @@ -42,10 +40,6 @@ export abstract class BoxDomainObject extends SolidDomainObject { | |||
| // OVERRIDES of DomainObject | |||
| // ================================================== | |||
|
|
|||
| public override get icon(): IconName { | |||
There was a problem hiding this comment.
Not needed, implementation is already in the base class
| @@ -32,10 +30,6 @@ export abstract class CylinderDomainObject extends SolidDomainObject { | |||
| // OVERRIDES of DomainObject | |||
| // ================================================== | |||
|
|
|||
| public override get icon(): IconName { | |||
There was a problem hiding this comment.
Not needed, implementation is already in the base class
| @@ -36,6 +37,8 @@ export const cameraManagerMock = new Mock<CameraManager>() | |||
| }) | |||
| .setup((p) => p.getCameraState()) | |||
| .returns(cameraManagerGlobalCurrentCameraState as Required<CameraState>) | |||
| .setup((p) => p.getCamera) | |||
There was a problem hiding this comment.
Added this to the ,mock. It is needed.
| @@ -43,4 +43,16 @@ export const viewerMock = new Mock<Cognite3DViewer<DataSourceType>>() | |||
| .returns(fitCameraToModelsMock) | |||
| .setup((p) => p.requestRedraw) | |||
| .returns(vi.fn()) | |||
| .setup((p) => p.on) | |||
There was a problem hiding this comment.
Also needed in the unit tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5028 +/- ##
==========================================
+ Coverage 23.69% 24.31% +0.61%
==========================================
Files 686 686
Lines 36817 36809 -8
Branches 1275 1368 +93
==========================================
+ Hits 8725 8949 +224
+ Misses 27816 27584 -232
Partials 276 276
🚀 New features to boost your workflow:
|
nilscognite
requested review from
a team and
finnag
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description 📝
This test the classes