TLK-2709 - Github Tool Implementation review fixes

src/backend/chat/collate.py

@@ -63,10 +63,6 @@ async def rerank_and_chunk(
 
         chunked_outputs = []
         for output in tool_result["outputs"]:
-            if isinstance(output, ToolError):
-                reranked_results[tool_call_hashable] = tool_result
-                continue
-
             text = output.get("text")
 
             if not text:

src/backend/tools/base.py

@@ -164,12 +164,13 @@ def get_tool_error(cls, details: str, text: str = "Error calling tool", error_ty
 
     @classmethod
     def get_no_results_error(cls):
-        return ToolError(text="No results found.", details="No results found for the given params.")
+        tool_error = ToolError(text="No results found.", details="No results found for the given params.").model_dump()
+        return [tool_error]
 
     @abstractmethod
     async def call(
             self, parameters: dict, ctx: Any, **kwargs: Any
-    ) -> Union[List[Dict[str, Any]], ToolError]:
+    ) -> List[Dict[str, Any]]:
         ...
 
     @classmethod

src/backend/tools/github/client.py

@@ -1,8 +1,10 @@
 from github import Auth, Github
 
+from backend.tools.github.constants import SEARCH_LIMIT
+
 
 class GithubClient:
-    def __init__(self, auth_token, search_limit=20):
+    def __init__(self, auth_token, search_limit=SEARCH_LIMIT):
         auth = Auth.Token(auth_token)
         self.client = Github(auth=auth, per_page=search_limit)