infra: Enable integration tests for all PRs and fix broken tests #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malexw
requested review from
EugeneLightsOn,
scottmx81,
tianjing-li and
a team
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
==========================================
- Coverage 79.27% 79.27% -0.01%
==========================================
Files 251 251
Lines 10654 10657 +3
==========================================
+ Hits 8446 8448 +2
- Misses 2208 2209 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
tianjing-li
reviewed
Nov 7, 2024
|
Could you follow up with Luisa if any keys need to be added for huggingface, otherwise we can disable the failing tests |
Will do |
tianjing-li
approved these changes
Nov 10, 2024
malexw
deleted the
alexw/tlk-1950-enable-backend-integration-tests-per-pr
branch
enzoxic
added a commit
to enzoxic/cohere-toolkit
that referenced
this pull request
Nov 24, 2024
commit 5502d8d Author: Tianjing Li <tianjinglimail@gmail.com> Date: Fri Nov 22 10:26:22 2024 -0500 backend: Hybrid Search improvements (cohere-ai#845) * Streamline hybrid search tool * Remove unit test config * Fix tool error call * Get definition * Fix implementation key * Fix tool call tests * Remove uneeded if condition commit 7b586db Author: Danylo Boiko <55975773+danylo-boiko@users.noreply.github.com> Date: Fri Nov 22 17:26:09 2024 +0200 tests: add the ability to specify a specific test for unit and community tests (cohere-ai#851) Add file params for unit and community tests commit 8cf04f8 Author: Tianjing Li <tianjinglimail@gmail.com> Date: Thu Nov 21 15:21:33 2024 -0500 docs: Improve tool docs & reflect current state (cohere-ai#843) * Add better docs * Update slack docs commit 37a6e2d Author: Danylo Boiko <55975773+danylo-boiko@users.noreply.github.com> Date: Thu Nov 21 21:17:04 2024 +0200 frontend: fix react-scroll-to-bottom import (cohere-ai#853) Fix import commit fa28503 Author: Danylo Boiko <55975773+danylo-boiko@users.noreply.github.com> Date: Thu Nov 21 12:02:43 2024 +0200 tests: add cleanup for containers used in integration tests (cohere-ai#852) Add --rm flag commit 13663b5 Author: Eugene P <144219719+EugeneLightsOn@users.noreply.github.com> Date: Wed Nov 20 16:18:54 2024 +0100 Azure compose deployment (cohere-ai#840) * TLK-1508 Azure deployment * TLK-1508 Azure deployment * TLK-1508 Azure deployment commit 8240e72 Author: Alex W <alex@lightsonsoftware.com> Date: Tue Nov 19 12:19:41 2024 -0500 infra: Enable integration tests for all PRs and fix broken tests (cohere-ai#833) Enable integration tests for all PRs and fix broken tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue that was causing two broken integration tests. (And in fact, the feature was broken but I don't think anyone noticed).
We also now can run integration tests for all PRs.
AI Description
This PR introduces changes to the backend integration tests and the conversation service.
Changes
backend_integration_tests.ymlfile now includes a new trigger for pull requests.conversation.pyfile has been updated to import theuuidmodule.create_message, has been added to theconversation.pyfile. This function is responsible for creating a message with specified parameters, including session, chat request, conversation ID, user ID, and message agent.generate_conversation_titlefunction in theconversation.pyfile now calls thecreate_messagefunction to generate a response message.