Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix make first-run command not setting proper Tavily api_key config #904

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

tianjing-li
Copy link
Collaborator

@tianjing-li tianjing-li commented Jan 13, 2025

Thank you for contributing to the Cohere Toolkit!

  • PR title: "area: description"

    • Where "area" is whichever of interface, frontend, model, tools, backend, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "deployment: add Azure model option"
  • PR message: Delete this entire checklist and replace with

    • Description: a description of the change
    • Issue: the issue # it fixes, if applicable
    • Dependencies: any dependencies required for this change
  • Add tests and docs: Please include testing and documentation for your changes

  • Lint and test: Run make lint and make run-unit-tests

AI Description

This PR updates the ENV_YAML_CONFIG_MAPPING dictionary in the constants.py file. The change involves modifying the path for the TAVILY_API_KEY entry, which now points to tools.tavily_web_search.api_key.

  • The TAVILY_API_KEY path is updated from tools.tavily.api_key to tools.tavily_web_search.api_key.
  • A comment is added, suggesting the use of the Settings class from the backend as a potential alternative approach.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (7426899) to head (c14bd16).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #904   +/-   ##
=======================================
  Coverage   77.84%   77.84%           
=======================================
  Files         259      259           
  Lines       11177    11177           
=======================================
  Hits         8701     8701           
  Misses       2476     2476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianjing-li tianjing-li merged commit f4d0172 into main Jan 13, 2025
7 of 8 checks passed
@tianjing-li tianjing-li deleted the fix-tavily-cli branch January 13, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants