Skip to content

Conversation

@For-ACGN
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Vein05 Vein05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Is the attribute that you added mentioned anywhere in the messagestruct in the API docs? Please provide a reference to the documentation before I can approve of changes.

Thank you!

@For-ACGN
Copy link
Contributor Author

image

Is the attribute that you added mentioned anywhere in the messagestruct in the API docs? Please provide a reference to the documentation before I can approve of changes.

Thank you!

I knew you were going to ask that, When I implemented external function calls before, after many attempts, I found that the lack of this field caused the call to fail.Like you, I checked the DeepSeek documentation and found that it was not written, but this field is required.

@For-ACGN
Copy link
Contributor Author

@Vein05 Vein05 self-assigned this Mar 11, 2025
@Vein05
Copy link
Collaborator

Vein05 commented Mar 11, 2025

I can approve of this change. Thank you for finding out a hidden documentation feature. If possible would you be able to create an issue about this so it's good for our documentation, and I can mention your issue in our releases. Also, you don't need to follow the issue format for that one. Just go over how you found out things, and if possible write example test data for testing. Here's an example to one I did: #8

You can reject to do this, just let me know. I will pull your changes nonetheless.

@For-ACGN
Copy link
Contributor Author

My personal guess is that the DeepSeek developers only tested it in Python, and the messages.append(message) in the demo code actually implicitly "inherits" tools, which caused them to omit the field when writing the document. Fortunately, when the field is omitted, the server error message will prompt you. And I can add a simple example tomorrow.
https://api-docs.deepseek.com/zh-cn/guides/function_calling

@Vein05 Vein05 merged commit f2a573d into cohesion-org:main Mar 11, 2025
1 check passed
@Vein05
Copy link
Collaborator

Vein05 commented Mar 11, 2025

Thank you!

I honestly did not know about this. I've merged your changes. Once you can create that issue, I will release a new version.

Best,
Sugam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants