VM migration code changes #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
naveena-maplelabs
commented
Jan 3, 2024
naveena-maplelabs
commented
- While creating restore tasks, if the task with same name is completed or cancelled, new task with same name is created.
- Support to filter tasks based on start and end time is added.
- By default last one week tasks will be returned. Supported format is DD/MM/YYYY
1) While creating restore tasks, if the task with same name is completed or cancelled, new task with same name is created. 2) Support to filter tasks based on start and end time is added. 3) By default last one week tasks will be returned. Supported format is DD/MM/YYYY
pyashish
reviewed
Jan 3, 2024
| @@ -25,7 +25,7 @@ | |||
| import json | |||
| import socket | |||
| import traceback | |||
|
|
|||
| from datetime import datetime, timedelta | |||
There was a problem hiding this comment.
is this in requirements this library ?
There was a problem hiding this comment.
Also I didnt see timedelta used anywhere ?
There was a problem hiding this comment.
timedelta is used at line number 587. datetime is inbuilt package.
There was a problem hiding this comment.
Ack, just make sure the package is autoinstalled on upgrade .
naveena-maplelabs
force-pushed
the
migrate_vm
branch
from
4593019 to
6a23415
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.