Bug Fix: SMB Source registration failure. #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveena-maplelabs
force-pushed
the
enhancements
branch
2 times, most recently
from
4aee810 to
3db4f96
Compare
shubhamkr-cohesity
approved these changes
Feb 19, 2024
Issue: 1) Registering SMB source fails if username contains @, format: user@domain 2) If user name is provided in following format: domain\username, source is registered but username is precede with slash. Fix: 1) Add fix to support above formats and tested the same
naveena-maplelabs
force-pushed
the
enhancements
branch
from
3db4f96 to
3139251
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
is registered but username is precede with slash.
Fix: