Temporarily disable log_telemetry_imported_packages
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI has run here 4 times successfully. I'm probably going to merge this in later today if nobody objects. Prohibiting this particular config option seems like it will have little impact of real-world users (the config option seems rather exotic?) while fixing the multithreading issue we've seen on |
j-bennet
reviewed
Jul 19, 2023
jrbourbeau
commented
Jul 19, 2023
There was a problem hiding this comment.
Thanks for the feedback @j-bennet, I appreciate it. Let's merge this in and track the upstream issue like you said (I've subscribed to it on GH so will see when progress is made)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It so happens we can just disable the non-thread safe functionality in the Snowflake connector highlighted in #51.
I think turning it off by default (with a meaningful error message when a users explicit wants it on) as a temporary workaround for snowflakedb/snowflake-connector-python#1648 makes sense.
@fjetter do you have bandwidth to review?