Open
Conversation
| bytes32 receiverOther; | ||
| // value sent | ||
| uint64 balance; | ||
| uint256 balance; |
Author
There was a problem hiding this comment.
unit256 and bytes32 is what the EVM gives you as default. Lowering the types makes it actual more gas costly in this instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for taking the lead on this @coin1111 !
I saw this PR today and took a few minutes of my work day to improve a few things in the contract - making it more idiomatic and adding a security check.
I also added a few improvements to running the scripts with npm. Hope you like it. You can let me know if you have any questions.