Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove sdk address #105

Merged
merged 2 commits into from
Sep 20, 2024
Merged

feat: Remove sdk address #105

merged 2 commits into from
Sep 20, 2024

Conversation

wangwzhou
Copy link
Contributor

What changed? Why?

  • Remove chainstorage sdk address
  • Remove Public APIs and other related info in readme

How did you test the change?

  • unit test
  • integration test
  • functional test
  • adhoc test (described below)

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 20, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@wangwzhou wangwzhou marked this pull request as ready for review September 20, 2024 00:56
@wangwzhou wangwzhou requested a review from a team as a code owner September 20, 2024 00:56
@wangwzhou wangwzhou merged commit 9ef4a74 into coinbase:master Sep 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwinchen12 edwinchen12 edwinchen12 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangwzhou @cb-heimdall @edwinchen12