Merge pull request #83 from coinbase/feat/dynamic-faucet-transaction-…

…links Dynamic faucet transaction links
coinbase · Jun 24, 2024 · 05e9f92 · 05e9f92
2 parents 67cd1b8 + 9a687e5
commit 05e9f92
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/src/client/api.ts b/src/client/api.ts
@@ -362,7 +362,7 @@ export interface CreateWalletRequestWallet {
     'use_server_signer'?: boolean;
 }
 /**
- * 
+ * The faucet transaction
  * @export
  * @interface FaucetTransaction
  */
@@ -373,6 +373,12 @@ export interface FaucetTransaction {
      * @memberof FaucetTransaction
      */
     'transaction_hash': string;
+    /**
+     * Link to the transaction on the blockchain explorer.
+     * @type {string}
+     * @memberof FaucetTransaction
+     */
+    'transaction_link': string;
 }
 /**
  * Features that can be enabled for a wallet

diff --git a/src/coinbase/faucet_transaction.ts b/src/coinbase/faucet_transaction.ts
@@ -37,8 +37,7 @@ export class FaucetTransaction {
    * @returns {string} The link to the transaction on the blockchain explorer
    */
   public getTransactionLink(): string {
-    // TODO: Parameterize this by Network.
-    return `https://sepolia.basescan.org/tx/${this.getTransactionHash()}`;
+    return this.model.transaction_link;
   }
 
   /**

diff --git a/src/coinbase/types.ts b/src/coinbase/types.ts
@@ -213,10 +213,7 @@ export type AddressAPIClient = {
    * @returns The transaction hash.
    * @throws {APIError} If the request fails.
    */
-  requestFaucetFunds(
-    walletId: string,
-    addressId: string,
-  ): Promise<{ data: { transaction_hash: string } }>;
+  requestFaucetFunds(walletId: string, addressId: string): AxiosPromise<FaucetTransaction>;
 
   /**
    * Get address by onchain address.

diff --git a/src/tests/faucet_transaction_test.ts b/src/tests/faucet_transaction_test.ts
@@ -4,6 +4,7 @@ describe("FaucetTransaction tests", () => {
   it("should create a new FaucetTransaction instance and return the transaction hash", () => {
     const faucetTransaction = new FaucetTransaction({
       transaction_hash: "abc",
+      transaction_link: "https://sepolia.basescan.org/tx/abc",
     });
 
     expect(faucetTransaction).toBeInstanceOf(FaucetTransaction);