Address comments: renaming to WalletAddress, added test case fixes

src/coinbase/address/developer_address.ts → src/coinbase/address/wallet_address.ts

@@ -15,14 +15,14 @@ import { delay } from "../utils";
 import { Wallet as WalletClass } from "../wallet";
 
 /**
- * A representation of a blockchain address, which is a developer-controlled account on a network.
+ * A representation of a blockchain address, which is a wallet-controlled account on a network.
  */
-export class DeveloperAddress extends Address {
+export class WalletAddress extends Address {
   private _model: AddressModel;
   private _key?: ethers.SigningKey;
 
   /**
-   * Initializes a new Developer Address instance.
+   * Initializes a new Wallet Address instance.
    *
    * @param model - The address model data.
    * @param key - The ethers.js SigningKey the Address uses to sign data.
@@ -39,12 +39,12 @@ export class DeveloperAddress extends Address {
   }
 
   /**
-   * Returns a string representation of the developer address.
+   * Returns a string representation of the wallet address.
    *
-   * @returns {string} A string representing the developer address.
+   * @returns {string} A string representing the wallet address.
    */
   public toString(): string {
-    return `Coinbase:DeveloperAddress{addressId: '${this.getId()}', networkId: '${this.getNetworkId()}', walletId: '${this.getWalletId()}'}`;
+    return `Coinbase:WalletAddress{addressId: '${this.getId()}', networkId: '${this.getNetworkId()}', walletId: '${this.getWalletId()}'}`;
   }
 
   /**
@@ -62,7 +62,7 @@ export class DeveloperAddress extends Address {
    * @param key - The ethers.js SigningKey the Address uses to sign data.
    * @throws {InternalError} If the private key is already set.
    */
-  public getKey(key: ethers.SigningKey) {
+  public setKey(key: ethers.SigningKey) {
     if (this._key !== undefined) {
       throw new InternalError("Private key is already set");
     }
@@ -258,7 +258,7 @@ export class DeveloperAddress extends Address {
    * @returns Whether the Address has a private key backing it to sign transactions.
    */
   public canSign(): boolean {
-    return !!this.getKey;
+    return !!this._key;
   }
 
   /**

src/coinbase/wallet.ts

@@ -23,7 +23,7 @@ import { BalanceMap } from "./balance_map";
 import Decimal from "decimal.js";
 import { Balance } from "./balance";
 import { Trade } from "./trade";
-import { DeveloperAddress } from "./address/developer_address";
+import { WalletAddress } from "./address/wallet_address";
 import { Asset } from "./asset";
 
 /**
@@ -36,7 +36,7 @@ export class Wallet {
 
   private master?: HDKey;
   private seed?: string;
-  private addresses: DeveloperAddress[] = [];
+  private addresses: WalletAddress[] = [];
   private addressModels: AddressModel[] = [];
 
   private readonly addressPathPrefix = "m/44'/60'/0'/0";
@@ -213,7 +213,7 @@ export class Wallet {
     const response = await Coinbase.apiClients.address!.createAddress(this.model.id!, payload);
 
     this.cacheAddress(response!.data, key);
-    return new DeveloperAddress(response!.data, key);
+    return new WalletAddress(response!.data, key);
   }
 
   /**
@@ -317,7 +317,7 @@ export class Wallet {
    * @returns {void}
    */
   private cacheAddress(address: AddressModel, key?: ethers.Wallet): void {
-    this.addresses.push(new DeveloperAddress(address, key?.signingKey));
+    this.addresses.push(new WalletAddress(address, key?.signingKey));
   }
 
   /**
@@ -547,7 +547,7 @@ export class Wallet {
    *
    * @returns The default address
    */
-  public getDefaultAddress(): DeveloperAddress | undefined {
+  public getDefaultAddress(): WalletAddress | undefined {
     return this.addresses.find(
       address => address.getId() === this.model.default_address?.address_id,
     );