[PSDK-117] Implement Transfer Class #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-peterson-coinbase
force-pushed
the
transfer-object
branch
4 times, most recently
from
ee98266
to
20f82fe
Compare
John-peterson-coinbase
changed the title
| @@ -66,6 +66,7 @@ | |||
| "text" | |||
| ], | |||
| "verbose": true, | |||
| "testRegex": ".test.ts$" | |||
| "testRegex": ".test.ts$", | |||
| "maxWorkers": 1 | |||
There was a problem hiding this comment.
This is needed for BigInt support in Jest
John-peterson-coinbase
force-pushed
the
transfer-object
branch
from
20f82fe
to
ea89618
Compare
erdimaden
reviewed
May 16, 2024
src/coinbase/transfer.ts
Outdated
Comment on lines
194
to
223
| const startTime = Date.now(); | ||
| while (Date.now() - startTime < timeoutSeconds * 1000) { | ||
| const status = await this.getStatus(); | ||
| if (status === TransferStatus.COMPLETE || status === TransferStatus.FAILED) { | ||
| return this; | ||
| } | ||
| await new Promise(resolve => setTimeout(resolve, intervalSeconds * 1000)); | ||
| } | ||
| throw new Error("Transfer timed out"); |
There was a problem hiding this comment.
We can create a function for this since we will use it in other classes too.
async function delay(seconds: number) {
return new Promise(resolve => setTimeout(resolve, seconds * 1000));
}
Also, we may want to consider to move wait function under utils folder.
John-peterson-coinbase
force-pushed
the
transfer-object
branch
from
ea89618
to
e0b9bf3
Compare
John-peterson-coinbase
force-pushed
the
transfer-object
branch
from
e0b9bf3
to
d538a1f
Compare
erdimaden
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
TransferclassTransferApiClienttypeTransferApiClienttoApiClientsFast-Follow
ListTransfersAddress.transferWallet.transferQualified Impact