Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getAbi return type on smart_contract #251

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix getAbi return type on smart_contract #251

merged 1 commit into from
Sep 18, 2024

Conversation

rohan-agarwal-coinbase
Copy link
Contributor

@rohan-agarwal-coinbase rohan-agarwal-coinbase commented Sep 18, 2024 •
edited
Loading

What changed? Why?

We had updated to use JSON.parse but I forgot to go from string -> object

Tested invokeContract locally successfully now by doing:

await addr.invokeContract({ contractAddress: sc.getContractAddress(), method: 'transfer', args: { to: newAddress.getId(), value: '1000000000000000000000' }, abi: sc.getAbi() });

Qualified Impact

@rohan-agarwal-coinbase rohan-agarwal-coinbase merged commit e7d8218 into v0.6.0 Sep 18, 2024
6 checks passed
@rohan-agarwal-coinbase rohan-agarwal-coinbase deleted the rohan/fix-abi branch September 18, 2024 21:35
rohan-agarwal-coinbase added a commit that referenced this pull request Sep 18, 2024
@rohan-agarwal-coinbase
Fix ABI object return type (#251)
127d3ed
alex-stone pushed a commit that referenced this pull request Sep 18, 2024
@rohan-agarwal-coinbase @alex-stone
Fix ABI object return type (#251)
d47edc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-stone alex-stone alex-stone approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohan-agarwal-coinbase @alex-stone