Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SDK's listAddressTransaction #260

Merged
merged 2 commits into from
Sep 20, 2024
Merged

update SDK's listAddressTransaction #260

merged 2 commits into from
Sep 20, 2024

Conversation

howard-at-cb
Copy link
Contributor

@howard-at-cb howard-at-cb commented Sep 19, 2024 •
edited
Loading

What changed? Why?

move listAddressTransactions under its own transactionHistory API

Qualified Impact

@howard-at-cb howard-at-cb changed the title Move tx history update SDK's listAddressTransaction Sep 19, 2024
@howard-at-cb howard-at-cb marked this pull request as ready for review September 20, 2024 00:21
alex-stone
alex-stone approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@alex-stone alex-stone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use "Squash and Merge" to land this!

@howard-at-cb howard-at-cb merged commit cf4030a into v0.7.0 Sep 20, 2024
9 checks passed
@howard-at-cb howard-at-cb deleted the move-tx-history branch September 20, 2024 20:26
facoinbase pushed a commit that referenced this pull request Oct 2, 2024
@howard-at-cb @facoinbase
update SDK's listAddressTransaction (#260)
2fd4646 
* listAddressTransaction

* Update coinbase.ts
John-peterson-coinbase pushed a commit that referenced this pull request Oct 4, 2024
@howard-at-cb @John-peterson-coinbase
update SDK's listAddressTransaction (#260)
4b9a1ce 
* listAddressTransaction

* Update coinbase.ts
John-peterson-coinbase added a commit that referenced this pull request Oct 4, 2024
@John-peterson-coinbase @facoinbase @howard-at-cb
Release v0.8.0 (#285)
49a1941 
* update rewards api to latest spec

* update generated client

* update SDK's listAddressTransaction (#260)

* listAddressTransaction

* Update coinbase.ts

* add examples

* allow updating address list of a wallet activity webhook (#280)

* test pass

* optional notif URI

* Update wallet.ts

* Update CHANGELOG.md

* Update CHANGELOG.md

* feat(PSDK-535): Explicit Pagination for list Methods (#282)

* feat(PSDK-535): Explicit Pagination for list Methods

* address comments

* chore: Release v0.8.0 (#283)

---------

Co-authored-by: Filipe Azevedo <filipeandre.martaazevedo@coinbase.com>
Co-authored-by: cb-howardatcb <86798563+howard-at-cb@users.noreply.github.com>
Co-authored-by: Filipe Azevedo <178675833+facoinbase@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb-davidlai cb-davidlai cb-davidlai approved these changes

@alex-stone alex-stone alex-stone approved these changes

@John-peterson-coinbase John-peterson-coinbase Awaiting requested review from John-peterson-coinbase

@jazz-cb jazz-cb Awaiting requested review from jazz-cb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howard-at-cb @alex-stone @cb-davidlai