Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding interfaces to relevant classes #277

Closed
wants to merge 12 commits into from
Closed

Adding interfaces to relevant classes #277

wants to merge 12 commits into from

Conversation

rohan-agarwal-coinbase
Copy link
Contributor

What changed? Why?

  • Adding interfaces to relevant classes in the same file and updated classes to use them

Followups before this PR is ready

  • Document the interfaces
  • Double check all the appropriate functions are being added in the interface

Main questions are:

  1. Do we like the interfaces in-line or do we want to consolidate to a specific file?

@cb-heimdall
Copy link

cb-heimdall commented Sep 27, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohan-agarwal-coinbase @cb-heimdall