Feat: Support assets dynamically from the backend #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdimaden
changed the title
jazz-cb
reviewed
Jun 19, 2024
src/coinbase/address.ts
Outdated
| @@ -253,19 +272,19 @@ export class Address { | |||
| * Creates a trade model for the specified amount and assets. | |||
| * | |||
| * @param amount - The amount of the Asset to send. | |||
| * @param fromAssetId - The ID of the Asset to trade from. For Ether, eth, gwei, and wei are supported. | |||
| * @param toAssetId - The ID of the Asset to trade to. For Ether, eth, gwei, and wei are supported. | |||
| * @param fromAsset - The Asset to trade from. For Ether, eth, gwei, and wei are supported. | |||
There was a problem hiding this comment.
remove For Ether, eth, gwei, and wei are supported.
There was a problem hiding this comment.
good catch! updated.
jazz-cb
reviewed
Jun 19, 2024
| break; | ||
| case "eth": | ||
| break; | ||
| default: |
There was a problem hiding this comment.
default should be break. we are supporting more erc20s on mainnet now https://docs-cdp-developer-platform-preview.cbhq.net/wallets/docs/assets/
There was a problem hiding this comment.
this is only for ETH, Wei, or Gwei usage. ERC20 tokens should not be able to bypass the model.asset_id !== Coinbase.toAssetId(assetId) guard.
erdimaden
force-pushed
the
feat/dynamic-assets
branch
from
765cd9c
to
788d694
Compare
jazz-cb
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This makes the SDK able to dynamically support any assets added from the backend.
Main changes
Qualified Impact