Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve NatSpec documentation and clean code #8

Merged
merged 6 commits into from
Mar 11, 2024
Merged

Improve NatSpec documentation and clean code #8

merged 6 commits into from
Mar 11, 2024

Conversation

xenoliss
Copy link
Contributor

@xenoliss xenoliss commented Mar 8, 2024 •
edited
Loading

This PR improves the NatSpec documentation of the MagicSpend contract.

It also brings minor cleaning changes:

  • Removes an unused import and error
  • Uses named parameters in mapping types
  • Removes the _toPrefixedMessageHash() wrapper and directly call SignatureCheckerLib.toEthSignedMessageHash() where needed

wilsoncusack
wilsoncusack reviewed Mar 11, 2024
View reviewed changes
src/MagicSpend.sol Outdated
import {IEntryPoint} from "account-abstraction/interfaces/IEntryPoint.sol";

/// @title Magic Spend
///
/// @author Coinbase (https://github.com/coinbase/smart-wallet)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong link :)

@wilsoncusack wilsoncusack merged commit 37fc113 into coinbase:main Mar 11, 2024
3 checks passed
@xenoliss xenoliss deleted the cleaning branch March 11, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsoncusack wilsoncusack wilsoncusack approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xenoliss @wilsoncusack