Bump up go and go-ethereum version #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoriver
changed the title
cryptoriver
force-pushed
the
update_go_eth
branch
from
6bb111f
to
df2cc9b
Compare
cryptoriver
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
go-ethereumversion from 1.10 to 1.12. The reason is because some rosetta nodes (e.g avalanche rosetta) are using more recent version and in order to use this SDK in these rosetta nodes, we need to bring it up to date as well.go-ethereumupdate, the old go version is no longer working as there's compile errors.One add-on benefit of this update is that it can support Cancun upgrade (the latest signer is the Cancun signer) using 1.12.
Solution
Bump up the version and update relevant code as there's a minor broken change.
Also need to update one unit test.
Tests
Note: Rosetta node that is dependent on this SDK and wants to take this new version will need to take care of the regression tests and any needed code change.
Open questions
N/A