Add value to EstimateGas request #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzdl-cb
approved these changes
Apr 16, 2024
|
Review Error for lzdl-cb @ 2024-04-16 18:30:08 UTC |
xiangliu-cb
force-pushed
the
xiang.liu/update-GetContractCallGasLimit
branch
from
eac7111
to
77dec74
Compare
lzdl-cb
approved these changes
Apr 16, 2024
|
Review Error for lzdl-cb @ 2024-04-16 18:48:26 UTC |
songge-cb
approved these changes
Apr 16, 2024
|
Review Error for songge-cb @ 2024-04-16 18:55:14 UTC |
GeekArthur
previously approved these changes
Apr 16, 2024
GeekArthur
approved these changes
Apr 16, 2024
xiangliu-cb
force-pushed
the
xiang.liu/update-GetContractCallGasLimit
branch
from
c1bfb27
to
075c45b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
StandardBridge is a base contract for the L1 and L2 standard ERC20 bridges. It will require
msg.valueinput when initBridgeETH. As a result, we need to pass value parameter in when leverage EstimateGas method from node.Solution
Add value to EstimateGas request
Open questions