Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support customized tx body #127

Merged
merged 1 commit into from
Jul 29, 2024
Merged

feat: support customized tx body #127

merged 1 commit into from
Jul 29, 2024

Conversation

GeekArthur
Copy link
Contributor

Fixes # .

Motivation

CL:

  • support customized block body with new tx type

Solution

Open questions

@GeekArthur
feat: support customized tx body
71e84ea 
Signed-off-by: Jingfu Wang <jingfu.wang@coinbase.com>
@cb-heimdall
Copy link

cb-heimdall commented Jul 29, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@GeekArthur GeekArthur merged commit aa8cc6d into coinbase:master Jul 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangliu-cb xiangliu-cb xiangliu-cb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeekArthur @cb-heimdall @xiangliu-cb