Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support customized block hash for balance API #128

Merged

Conversation

GeekArthur
Copy link
Contributor

Fixes # .

Motivation

Support customized block hash for balance API

Solution

Open questions

Signed-off-by: Jingfu Wang <jingfu.wang@coinbase.com>
@cb-heimdall
Copy link

cb-heimdall commented Aug 15, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 3/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Signed-off-by: Jingfu Wang <jingfu.wang@coinbase.com>
Signed-off-by: Jingfu Wang <jingfu.wang@coinbase.com>
Signed-off-by: Jingfu Wang <jingfu.wang@coinbase.com>
Signed-off-by: Jingfu Wang <jingfu.wang@coinbase.com>
shiatcb
shiatcb previously approved these changes Aug 15, 2024
Signed-off-by: Jingfu Wang <jingfu.wang@coinbase.com>
Signed-off-by: Jingfu Wang <jingfu.wang@coinbase.com>
shiatcb
shiatcb previously approved these changes Aug 15, 2024
Signed-off-by: Jingfu Wang <jingfu.wang@coinbase.com>
shiatcb
shiatcb previously approved these changes Aug 15, 2024
Signed-off-by: Jingfu Wang <jingfu.wang@coinbase.com>
@cb-heimdall
Copy link

Review Error for xiangliu-cb @ 2024-08-15 15:50:07 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@cb-heimdall
Copy link

Review Error for xiangliu-cb @ 2024-08-15 15:54:07 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@GeekArthur GeekArthur merged commit 6b9a6ce into coinbase:master Aug 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants