Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support bytes[] as the contract call args #130

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

yfl92
Copy link
Contributor

@yfl92 yfl92 commented Sep 27, 2024

Motivation

This PR adds logic to handle bytes[] contract call args

Test on Base Sepolia
https://sepolia.basescan.org/tx/0x61bca9ade0522b70524ebe3e9b3064572cd22e05cdd67d650ad8657dc0f8a1f4

Solution

Open questions

@cb-heimdall
Copy link

cb-heimdall commented Sep 27, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@yfl92 yfl92 marked this pull request as ready for review September 27, 2024 02:05
@cb-heimdall
Copy link

Review Error for GeekArthur @ 2024-09-27 14:42:02 UTC
User failed mfa authentication, see go/mfa-help

@yfl92 yfl92 merged commit 5f86092 into coinbase:master Sep 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants