-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve embedded tweet performance #1345
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| import { useEffect, useState } from 'react'; | ||
|
|
||
| const Tweets = () => { | ||
| const [scriptLoaded, setScriptLoaded] = useState(false); | ||
|
|
||
| useEffect(() => { | ||
| const script = document.createElement('script'); | ||
| script.src = 'https://platform.twitter.com/widgets.js'; | ||
| script.async = true; | ||
|
|
||
| // Set script onload to true when it's loaded | ||
| script.onload = () => { | ||
| setScriptLoaded(true); | ||
| }; | ||
|
|
||
| // Set script onerror to handle failure to load | ||
| script.onerror = () => { | ||
| setScriptLoaded(false); | ||
| }; | ||
|
|
||
| document.body.appendChild(script); | ||
|
|
||
| // Cleanup the script when the component unmounts | ||
| return () => { | ||
| document.body.removeChild(script); | ||
| }; | ||
| }, []); | ||
|
|
||
| if (!scriptLoaded) { | ||
| // If the script isn't loaded yet, return null. | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <section className="css-alternate-container flex w-full flex-col items-center gap-[72px] py-24"> | ||
| <div> | ||
| <h3 className="max-w-[525px] basis-1/2 py-[15px] text-center text-4xl text-gray-950 md:text-4xl dark:text-gray-50"> | ||
| Builders ship faster with OnchainKit | ||
| </h3> | ||
| </div> | ||
| <div className="flex flex-col items-center gap-6 md:flex-row md:items-start"> | ||
| <div className="flex w-full max-w-[438px] justify-center"> | ||
| <blockquote | ||
| className="twitter-tweet tweet1" | ||
| data-dnt="true" | ||
| data-theme="dark" | ||
| > | ||
| <p lang="en" dir="ltr"> | ||
| 🟣 Excited to announce that Basenames are now integrated into the | ||
| Fit Club app! <br /> | ||
| <br /> | ||
| Thanks to{' '} | ||
| <a href="https://twitter.com/OnchainKit?ref_src=twsrc%5Etfw"> | ||
| @OnchainKit | ||
| </a>{' '} | ||
| for making it smooth and easy! 💜 | ||
| <br /> | ||
| <br /> | ||
| More updates on the way, stay fit. 🏋️♀️🏋️♂️{' '} | ||
| <a href="https://t.co/5BlIm5kSx3">pic.twitter.com/5BlIm5kSx3</a> | ||
| </p> | ||
| — Fit Club (@fitclubonbase){' '} | ||
| <a href="https://twitter.com/fitclubonbase/status/1826969613294334172?ref_src=twsrc%5Etfw"> | ||
| August 23, 2024 | ||
| </a> | ||
| </blockquote> | ||
| </div> | ||
| <div className="flex max-w-[648px] flex-col items-center gap-6 md:items-start"> | ||
| <blockquote | ||
| className="twitter-tweet tweet2" | ||
| data-dnt="true" | ||
| data-theme="dark" | ||
| > | ||
| <p lang="en" dir="ltr"> | ||
| The{' '} | ||
| <a href="https://twitter.com/OnchainKit?ref_src=twsrc%5Etfw"> | ||
| @OnchainKit | ||
| </a>{' '} | ||
| makes me happy as a developer and excited to write some code | ||
| again. | ||
| </p> | ||
| — GoodDev (@YourGoodDev){' '} | ||
| <a href="https://twitter.com/YourGoodDev/status/1839180292268937665?ref_src=twsrc%5Etfw"> | ||
| September 26, 2024 | ||
| </a> | ||
| </blockquote> | ||
| <blockquote | ||
| className="twitter-tweet tweet3" | ||
| data-conversation="none" | ||
| data-dnt="true" | ||
| data-theme="dark" | ||
| > | ||
| <p lang="en" dir="ltr"> | ||
| Swap is now live on our website! Feels good to be based, thanks | ||
| guys 💙{' '} | ||
| <a href="https://t.co/vunDYrnT2j">pic.twitter.com/vunDYrnT2j</a> | ||
| </p> | ||
| — KEYCAT (@KeyboardCatBase){' '} | ||
| <a href="https://twitter.com/KeyboardCatBase/status/1838710257809252581?ref_src=twsrc%5Etfw"> | ||
| September 24, 2024 | ||
| </a> | ||
| </blockquote> | ||
| </div> | ||
| </div> | ||
| </section> | ||
| ); | ||
| }; | ||
|
|
||
| export default Tweets; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only load the widget script once...was previously loading for each tweet