Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: toast animations #1620

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Feat: toast animations #1620

merged 5 commits into from
Nov 15, 2024

Conversation

brendan-defi
Copy link
Contributor

@brendan-defi brendan-defi commented Nov 13, 2024

What changed? Why?

  • fixed stuttering issue with Toast animations
  • create two new animation types (enterUp and enterDown)
  • created default animation behavior based on position
  • added animation prop to Toast to override default

Notes to reviewers

How has it been tested?

  • full test coverage
  • locally in playground

@github-actions github-actions bot added the root label Nov 13, 2024
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
onchainkit-coverage ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 6:59pm
onchainkit-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 6:59pm
onchainkit-routes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 6:59pm

@alessey
Copy link
Contributor

alessey commented Nov 15, 2024

cc: @alissacrane-cb was there a requirement around animations always coming in from the right?

@brendan-defi brendan-defi merged commit 31afa2e into main Nov 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants