Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to FAQ about tx.origin #103

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Add note to FAQ about tx.origin #103

merged 1 commit into from
Dec 7, 2024

Conversation

amiecorso
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smart-wallet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 9:23pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 6, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@eric-ships eric-ships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cb-heimdall
Copy link
Collaborator

Review Error for eric-ships @ 2024-12-06 22:53:46 UTC
User failed mfa authentication, see go/mfa-help

@amiecorso amiecorso merged commit 2185e0a into main Dec 7, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants