Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Doc for MSDK 1.0.0 #105

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Update Doc for MSDK 1.0.0 #105

merged 1 commit into from
Dec 12, 2024

Conversation

fan-zhang-sv
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smart-wallet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 7:03pm

@fan-zhang-sv fan-zhang-sv requested a review from cb-jake December 12, 2024 19:03
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 12, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Comment on lines +24 to +25
Breaking change in v1.0.0: Universal Links and App Links requirements are
removed in favor of custom schemes (e.g. `myapp://`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this iOS only? Should we make this iOS only and still require app links for android?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is removed for both android and ios on 1.0.0. will take an action item on evaluating the security of android implementation

@fan-zhang-sv fan-zhang-sv merged commit df52e43 into main Dec 12, 2024
6 checks passed
@cb-jake cb-jake deleted the felix/msdk-1.0.0 branch December 12, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants