Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Networks: Adding Network Support #110

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Networks: Adding Network Support #110

merged 4 commits into from
Dec 17, 2024

Conversation

eric-ships
Copy link
Contributor

@eric-ships eric-ships commented Dec 17, 2024 •
edited
Loading

I added a section for what it would take to add network support.

Screenshot 2024-12-17 at 2 58 28 PM

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smart-wallet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 10:58pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 17, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

ajhodges
ajhodges suggested changes Dec 17, 2024
View reviewed changes
Copy link

@ajhodges ajhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to include some pointers I think

docs/pages/features/networks.mdx Outdated Show resolved Hide resolved
docs/pages/features/networks.mdx Outdated Show resolved Hide resolved
docs/pages/features/networks.mdx Outdated Show resolved Hide resolved
@cb-heimdall
Copy link
Collaborator

Review Error for ajhodges @ 2024-12-17 15:37:40 UTC
User must have write permissions to review

amiecorso
amiecorso previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@amiecorso amiecorso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment. thanks for all these docs updates this is great!

@cb-heimdall cb-heimdall dismissed amiecorso’s stale review December 17, 2024 22:55

Approved review 2509416840 from amiecorso is now dismissed due to new commit. Re-request for approval.

@cb-heimdall
Copy link
Collaborator

Review Error for ajhodges @ 2024-12-17 23:06:07 UTC
User must have write permissions to review

@eric-ships eric-ships merged commit f36ffd4 into main Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajhodges-cb ajhodges-cb ajhodges-cb approved these changes

@ajhodges ajhodges ajhodges approved these changes

@lukasrosario lukasrosario Awaiting requested review from lukasrosario

@ilikesymmetry ilikesymmetry Awaiting requested review from ilikesymmetry

@cb-jake cb-jake Awaiting requested review from cb-jake

@amiecorso amiecorso Awaiting requested review from amiecorso

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eric-ships @cb-heimdall @ajhodges @amiecorso @ajhodges-cb