-
Notifications
You must be signed in to change notification settings - Fork 12
Smart wallet mobile SDK 0.1.0 doc update #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just left a couple of minor wording changes
@@ -187,6 +192,9 @@ yarn add @mobile-wallet-protocol/wagmi-connectors@latest | |||
|
|||
Simply import the `createConnectorFromWallet` function and pass in the wallet you want to use to wagmi config. | |||
|
|||
<Callout type="success" > | |||
A new config `appCustomScheme` is introduced to remove the Done screen after signing. | |||
</Callout> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks the same as above. Redundant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we provide 2 interfaces here, some user may jump right into the second one, would like to emphasize in both section
Co-authored-by: Nate <nate.reiners@gmail.com>
Co-authored-by: Nate <nate.reiners@gmail.com>
No description provided.