Skip to content

Smart wallet mobile SDK 0.1.0 doc update #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

fan-zhang-sv
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smart-wallet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 4:29pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 10, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@nateReiners nateReiners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just left a couple of minor wording changes

@@ -187,6 +192,9 @@ yarn add @mobile-wallet-protocol/wagmi-connectors@latest

Simply import the `createConnectorFromWallet` function and pass in the wallet you want to use to wagmi config.

<Callout type="success" >
A new config `appCustomScheme` is introduced to remove the Done screen after signing.
</Callout>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks the same as above. Redundant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we provide 2 interfaces here, some user may jump right into the second one, would like to emphasize in both section

fan-zhang-sv and others added 2 commits October 10, 2024 20:13
Co-authored-by: Nate <nate.reiners@gmail.com>
Co-authored-by: Nate <nate.reiners@gmail.com>
@nateReiners nateReiners merged commit f1e1493 into coinbase:main Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants