Use an EOA for our spender, simplify tutorial #92
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟡 Heimdall Review Status
|
amiecorso
changed the base branch from
main
to
amie/realtime-buildbash-feedback
| You can create a new Smart Wallet via the popup. Note that you'll need a little ETH in this wallet to fund the | ||
| deployment of your account. If you don't have any testnet ETH, try this [Coinbase faucet](https://portal.cdp.coinbase.com/products/faucet). | ||
|
|
||
| Once your wallet is created and funded, return to the app and click "Subscribe". | ||
| Sign the prompts, which will deploy your new Smart Wallet (if undeployed), and then prompt you to sign over the spend permission. | ||
| Before you continue, note that you'll also need a little testnet ETH in your spender wallet, which will need to fund the gas for the transactions. |
There was a problem hiding this comment.
| You can create a new Smart Wallet via the popup. Note that you'll need a little ETH in this wallet to fund the | |
| deployment of your account. If you don't have any testnet ETH, try this [Coinbase faucet](https://portal.cdp.coinbase.com/products/faucet). | |
| Once your wallet is created and funded, return to the app and click "Subscribe". | |
| Sign the prompts, which will deploy your new Smart Wallet (if undeployed), and then prompt you to sign over the spend permission. | |
| Before you continue, note that you'll also need a little testnet ETH in your spender wallet, which will need to fund the gas for the transactions. | |
| Note that we'll need a little bit of base sepolia ETH in both wallet addresses (the "user" wallet and the "app" wallet). In a more involved implementation you would use a paymaster to eliminate this requirement. For now, If you don't have any base sepolia ETH, try this [Coinbase faucet](https://portal.cdp.coinbase.com/products/faucet). |
Do we actually require funds in the user wallet? Wouldn't the dapp's wallet be deploying the user's account during execution?
There was a problem hiding this comment.
while I don't ever see the wallet prompt me to deploy it, I do see a warning screen if I have 0 ETH in the wallet with some buttons including the option to "Fund wallet". So while the user may not require ETH in a functional sense, something in our system is enforcing that
There was a problem hiding this comment.
(ultimately they will require at least a little ETH if the dev wants to see the app work end-to-end because there needs to be a little for the spender to spend)
There was a problem hiding this comment.
Gotcha. If the dapp requests a base asset (i.e. ETH) then the user will be prompted to fund before granting (so the dapp has something to spend). If the dapp requests an erc20 in an ideal world we'd probably ask the user to fund there as well, but in the current world we just let the user grant the permission without funding.
| Before you continue, note that you'll also need a little testnet ETH in your spender wallet, which will need to fund the gas for the transactions. | ||
|
|
||
| Once your wallet is created and both wallets are funded, return to the app and click "Subscribe". | ||
| Sign the prompts, which will deploy your new Smart Wallet (if undeployed), and then prompt you to sign the spend permission requested by the app. |
There was a problem hiding this comment.
I don't think we prompt to deploy here - and if we did for base sepolia the default paymaster would handle funds for us
There was a problem hiding this comment.
got it -- yeah as I mentioned in my comment above, I don't see this when I just tried it fresh so will remove
amiecorso
changed the base branch from
amie/realtime-buildbash-feedback
to
main
cb-heimdall
dismissed stale reviews from spencerstock and ilikesymmetry
Approved review 2424707245 from spencerstock is now dismissed due to new commit. Re-request for approval.
|
Review Error for ilikesymmetry @ 2024-11-08 20:05:00 UTC |
Significantly speeds up the quickstart to use an EOA for our spender.