Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cleanup #96

Merged
merged 2 commits into from
Nov 12, 2024
Merged

More cleanup #96

merged 2 commits into from
Nov 12, 2024

Conversation

amiecorso
Copy link
Contributor

@amiecorso amiecorso commented Nov 11, 2024

  • uses npm across the board, since the project created by either bun create onchain or npm create onchain cite npm as the package manager in the subsequent instructions.
  • eliminates the need for unused CDP API and paymaster environment variables
  • fixes an import to be consistent with the instructions
  • incorporates some buildbash feedback about terminology for some of the observational steps
  • fixes a typo in the overview
  • removes targetName from api endpoint per this thread

Otherwise, I followed these steps verbatim and ended up with a working project! 🎉

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
smart-wallet-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 5:01pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 11, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link
Contributor

@spencerstock spencerstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for the quality here.

@amiecorso amiecorso merged commit 2d23ead into main Nov 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants