Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MDS-1000 add role prop for Popover.Trigger #2551

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

yarema184
Copy link
Collaborator

Role attribute for subcomponent Popover.Trigger is hardcoded as 'button'. In rare cases, it is necessary to change this attribute from outside.

For this, we need to add 'role' props for the subcomponent Popover.Trigger

Checklist

  • You attached screenshots or added description about changes
  • You use conventional commits naming, e.g. fix: your changes description [TicketNumber], feat: your feature name [TicketNumber]
  • You have updated the documentation accordingly.

@yarema184 yarema184 requested a review from a team as a code owner February 19, 2024 07:43
Copy link

changeset-bot bot commented Feb 19, 2024

⚠️ No Changeset found

Latest commit: be889fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@karl-kallavus karl-kallavus merged commit 5243132 into develop Feb 19, 2024
7 checks passed
@karl-kallavus karl-kallavus deleted the MDS-1000 branch February 19, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants