Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SBFE-1104 -> add possibility to disable focus lock on Dialog component #2563

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

MartinezEst
Copy link
Contributor

Added new property to Dialog -> disableFocusLock

Screenshot and description

It fixes the bug we are facing in -> https://coingaming.atlassian.net/browse/SBFE-1104
Related in this issue -> #2562

Checklist

  • You attached screenshots or added description about changes
  • You use conventional commits naming, e.g. fix: your changes description [TicketNumber], feat: your feature name [TicketNumber]
  • You have updated the documentation accordingly.

@MartinezEst MartinezEst requested a review from a team as a code owner March 13, 2024 13:59
Copy link

changeset-bot bot commented Mar 13, 2024

⚠️ No Changeset found

Latest commit: ee36664

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@heathmont/moon-base-tw" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@heathmont/moon-cmdk-tw" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@heathmont/moon-core-tw" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
The package or glob expression "@heathmont/moon-themes-tw" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@karl-kallavus karl-kallavus merged commit 9132a69 into develop Mar 14, 2024
7 checks passed
@karl-kallavus karl-kallavus deleted the SBFE-1104 branch March 14, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants