Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for package augmentation #49

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

luca-della-vedova
Copy link
Member

I was a bit worried about the low coverage of the PR so I added some tests for dependencies as well as metadata

Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.07%. Comparing base (c67bab0) to head (7f17199).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           cottsay/package-augmentation      #49       +/-   ##
=================================================================
+ Coverage                         56.92%   68.07%   +11.15%     
=================================================================
  Files                                 7        7               
  Lines                               260      260               
  Branches                             44       44               
=================================================================
+ Hits                                148      177       +29     
+ Misses                               89       55       -34     
- Partials                             23       28        +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cottsay cottsay merged commit eac2819 into cottsay/package-augmentation Dec 9, 2024
17 checks passed
@cottsay cottsay deleted the luca/augmentation_test branch December 9, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants