test_result: skip gtest summaries to reduce number of duplicates in output #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported in colcon/colcon-test-result#44, of gtest results being shown both from the xunit report generated by gtest itself, and the ctest report of executing the entire gtest executable.
I'm not sure if this is actually good, one downside is that the full gtest output (including for example stdout of the test) is not shown anymore, as this is only included in the ctest report. The gtest xunit report only contains the error message. I found this not very problematic and the tradeoff worthwile, as the gtest output recorded in the ctest report is not very useful anyways because it strips any color.
GTEST_COLOR=1 colcon test (--packges-select ...) --event-handlers console_cohesion+is the only useful way for me to get this.I think it might be worthwhile to special-case this, as it is a very common and often the first type of test added to a ROS package, and the colcon testing workflow is confusing enough already...